Keep ImageManager primitives free of private debug headers (#58792)

Summary:
Pull Request resolved: #58792

The public `react/renderer/imagemanager/primitives.h` header included the private `react/renderer/debug/debugStringConvertibleUtils.h` for the inline body of `ImageSource::getDebugProps()`. Because the include was unconditional, any strict consumer of `<React/ImageManager.h>` or `<React/Image.h>` (which reaches `primitives.h` through the Image event emitter) hit the private header guard and failed to compile.

Include the public `DebugStringConvertible.h` and `flags.h` headers instead, which provide `SharedDebugStringConvertibleList` and `RN_DEBUG_STRING_CONVERTIBLE`, and keep only the `getDebugProps()` declaration in the header under the existing `RN_DEBUG_STRING_CONVERTIBLE` guard. Move its unchanged implementation into a new `primitives.cpp`, the only place that needs the private debug helpers. Buck, CMake, and CocoaPods already compile every `imagemanager/*.cpp`, so no build-file changes are needed.

Changelog: [Internal]

___

Reviewed By: cortinico

Differential Revision: D122534446

fbshipit-source-id: 61759cd5041c4ac7571ae2d5e3ab9bc8c28b1ef5

Author: coado

packages/react-native/ReactCommon/react/renderer/imagemanager/primitives.cpp

@@ -0,0 +1,49 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include <react/renderer/imagemanager/primitives.h>
+
+#if RN_DEBUG_STRING_CONVERTIBLE
+#include <react/renderer/debug/debugStringConvertibleUtils.h>
+#endif
+
+namespace facebook::react {
+
+#if RN_DEBUG_STRING_CONVERTIBLE
+SharedDebugStringConvertibleList ImageSource::getDebugProps(
+    const std::string& prefix) const {
+  ImageSource imageSource{};
+
+  SharedDebugStringConvertibleList headersList;
+  for (const auto& header : headers) {
+    headersList.push_back(debugStringConvertibleItem(
+        prefix + "-header-" + header.first, header.second));
+  }
+
+  return headersList +
+      SharedDebugStringConvertibleList{
+          debugStringConvertibleItem(
+              prefix + "-type", toString(type), toString(imageSource.type)),
+          debugStringConvertibleItem(prefix + "-uri", uri, imageSource.uri),
+          debugStringConvertibleItem(
+              prefix + "-bundle", bundle, imageSource.bundle),
+          debugStringConvertibleItem(
+              prefix + "-scale", scale, imageSource.scale),
+          debugStringConvertibleItem(
+              prefix + "-size",
+              react::toString(size),
+              react::toString(imageSource.size)),
+          debugStringConvertibleItem(prefix + "-body", body, imageSource.body),
+          debugStringConvertibleItem(
+              prefix + "-method", method, imageSource.method),
+          debugStringConvertibleItem(
+              prefix + "-cache", toString(cache), toString(imageSource.cache)),
+      };
+}
+#endif
+
+} // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/imagemanager/primitives.h

@@ -16,7 +16,8 @@
 #include <React/Graphics.h>
 #include <React/RendererCore.h>
 #include <React/RendererDebug.h>
-#include <react/renderer/debug/debugStringConvertibleUtils.h>
+#include <react/renderer/debug/DebugStringConvertible.h>
+#include <react/renderer/debug/flags.h>
 
 namespace facebook::react {
 
@@ -96,27 +97,7 @@ class ImageSource {
 #endif
 
 #if RN_DEBUG_STRING_CONVERTIBLE
-  SharedDebugStringConvertibleList getDebugProps(const std::string &prefix) const
-  {
-    ImageSource imageSource{};
-
-    SharedDebugStringConvertibleList headersList;
-    for (const auto &header : headers) {
-      headersList.push_back(debugStringConvertibleItem(prefix + "-header-" + header.first, header.second));
-    }
-
-    return headersList +
-        SharedDebugStringConvertibleList{
-            debugStringConvertibleItem(prefix + "-type", toString(type), toString(imageSource.type)),
-            debugStringConvertibleItem(prefix + "-uri", uri, imageSource.uri),
-            debugStringConvertibleItem(prefix + "-bundle", bundle, imageSource.bundle),
-            debugStringConvertibleItem(prefix + "-scale", scale, imageSource.scale),
-            debugStringConvertibleItem(prefix + "-size", react::toString(size), react::toString(imageSource.size)),
-            debugStringConvertibleItem(prefix + "-body", body, imageSource.body),
-            debugStringConvertibleItem(prefix + "-method", method, imageSource.method),
-            debugStringConvertibleItem(prefix + "-cache", toString(cache), toString(imageSource.cache)),
-        };
-  }
+  SharedDebugStringConvertibleList getDebugProps(const std::string &prefix) const;
 
   std::string toString(const Type &typeValue) const
   {