From 469bff82d7c3fb1c75fc68d43e03cfc97ec8e504 Mon Sep 17 00:00:00 2001 From: unknown Date: Thu, 16 Jul 2026 21:55:03 +0530 Subject: [PATCH] fix: remove User.api_v2_token property returning plaintext API token (#3047) --- apps/downloads/tests/test_views.py | 3 ++- apps/users/models.py | 10 ---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/apps/downloads/tests/test_views.py b/apps/downloads/tests/test_views.py index a070d499f..3adfd2943 100644 --- a/apps/downloads/tests/test_views.py +++ b/apps/downloads/tests/test_views.py @@ -16,6 +16,7 @@ from apps.pages.factories import PageFactory from apps.users.factories import UserFactory from pydotorg.drf import BaseAPITestCase +from rest_framework.authtoken.models import Token User = get_user_model() @@ -179,7 +180,7 @@ def setUp(self): password="passworduser", is_staff=True, ) - self.Authorization = f"Token {self.staff_user.api_v2_token}" + self.Authorization = f"Token {Token.objects.get(user=self.staff_user).key}" self.Authorization_invalid = "Token invalid-token" def get_json(self, response): diff --git a/apps/users/models.py b/apps/users/models.py index 3d67fef5b..9be89b874 100644 --- a/apps/users/models.py +++ b/apps/users/models.py @@ -8,7 +8,6 @@ from django.urls import reverse from django.utils import timezone from markupfield.fields import MarkupField -from rest_framework.authtoken.models import Token from tastypie.models import create_api_key from apps.users.managers import UserManager @@ -73,15 +72,6 @@ def sponsorships(self): return Sponsorship.objects.visible_to(self) - @property - def api_v2_token(self): - """Return the user's DRF API token key, or empty string if none exists.""" - try: - return Token.objects.get(user=self).key - except Token.DoesNotExist: - return "" - - models.signals.post_save.connect(create_api_key, sender=User)