Skip to content

Commit 58306fe

Browse files
committed
gh-145306: keep a single regression test
1 parent 36a4289 commit 58306fe

File tree

1 file changed

+1
-83
lines changed
  • Lib/test/test_profiling/test_sampling_profiler

1 file changed

+1
-83
lines changed

Lib/test/test_profiling/test_sampling_profiler/test_cli.py

Lines changed: 1 addition & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from test.support import is_emscripten, requires_remote_subprocess_debugging
1818

19-
from profiling.sampling.cli import _handle_output, _handle_replay, main
19+
from profiling.sampling.cli import _handle_output, main
2020
from profiling.sampling.errors import SamplingScriptNotFoundError, SamplingModuleNotFoundError, SamplingUnknownProcessError
2121

2222
class TestSampleProfilerCLI(unittest.TestCase):
@@ -719,88 +719,6 @@ def test_handle_output_browser_not_opened_when_export_fails(self):
719719
collector.export.assert_called_once_with("profile.html")
720720
mock_open.assert_not_called()
721721

722-
def test_handle_output_browser_opened_when_export_succeeds(self):
723-
collector = mock.MagicMock()
724-
collector.export.return_value = True
725-
args = SimpleNamespace(
726-
format="flamegraph",
727-
outfile="profile.html",
728-
browser=True,
729-
)
730-
731-
with (
732-
mock.patch("profiling.sampling.cli.os.path.isdir", return_value=False),
733-
mock.patch("profiling.sampling.cli._open_in_browser") as mock_open,
734-
):
735-
_handle_output(collector, args, pid=12345, mode=0)
736-
737-
collector.export.assert_called_once_with("profile.html")
738-
mock_open.assert_called_once_with("profile.html")
739-
740-
def test_replay_browser_not_opened_when_export_fails(self):
741-
args = SimpleNamespace(
742-
input_file="profile.bin",
743-
format="flamegraph",
744-
outfile="profile.html",
745-
browser=True,
746-
sort=None,
747-
limit=None,
748-
no_summary=False,
749-
)
750-
collector = mock.MagicMock()
751-
collector.export.return_value = False
752-
753-
with (
754-
mock.patch("profiling.sampling.cli.os.path.exists", return_value=True),
755-
mock.patch("profiling.sampling.cli.BinaryReader") as mock_reader_cls,
756-
mock.patch("profiling.sampling.cli._create_collector", return_value=collector),
757-
mock.patch("profiling.sampling.cli._open_in_browser") as mock_open,
758-
):
759-
reader = mock_reader_cls.return_value.__enter__.return_value
760-
reader.get_info.return_value = {
761-
"sample_count": 1,
762-
"sample_interval_us": 1000,
763-
"compression_type": 0,
764-
}
765-
reader.replay_samples.return_value = 1
766-
767-
_handle_replay(args)
768-
769-
collector.export.assert_called_once_with("profile.html")
770-
mock_open.assert_not_called()
771-
772-
def test_replay_browser_opened_when_export_succeeds(self):
773-
args = SimpleNamespace(
774-
input_file="profile.bin",
775-
format="flamegraph",
776-
outfile="profile.html",
777-
browser=True,
778-
sort=None,
779-
limit=None,
780-
no_summary=False,
781-
)
782-
collector = mock.MagicMock()
783-
collector.export.return_value = True
784-
785-
with (
786-
mock.patch("profiling.sampling.cli.os.path.exists", return_value=True),
787-
mock.patch("profiling.sampling.cli.BinaryReader") as mock_reader_cls,
788-
mock.patch("profiling.sampling.cli._create_collector", return_value=collector),
789-
mock.patch("profiling.sampling.cli._open_in_browser") as mock_open,
790-
):
791-
reader = mock_reader_cls.return_value.__enter__.return_value
792-
reader.get_info.return_value = {
793-
"sample_count": 1,
794-
"sample_interval_us": 1000,
795-
"compression_type": 0,
796-
}
797-
reader.replay_samples.return_value = 1
798-
799-
_handle_replay(args)
800-
801-
collector.export.assert_called_once_with("profile.html")
802-
mock_open.assert_called_once_with("profile.html")
803-
804722
@unittest.skipIf(is_emscripten, "subprocess not available")
805723
def test_run_nonexistent_script_exits_cleanly(self):
806724
"""Test that running a non-existent script exits with a clean error."""

0 commit comments

Comments
 (0)