Fixed Bit.from_binary with negative length - resolves #173

Co-authored-by: beyondsundial <67931863+beyondsundial@users.noreply.github.com>

Author: ankane

pgvector/bit.py

@@ -88,7 +88,7 @@ def from_binary(cls, value: bytes | bytearray | memoryview, /) -> Bit:
         length, = unpack_from('>i', value)
         data = memoryview(value)[4:].tobytes()
 
-        if len(data) != (length + 7) // 8:
+        if length < 0 or len(data) != (length + 7) // 8:
             raise ValueError('invalid length')
 
         bit = cls.__new__(cls)

tests/test_bit.py

@@ -110,3 +110,8 @@ def test_from_binary(self) -> None:
         if np is not None:
             assert np.array_equal(vec.to_numpy(), [True, False, True])
         assert vec.to_binary() == data
+
+    def test_from_binary_negative_length(self) -> None:
+        with pytest.raises(ValueError) as error:
+            Bit.from_binary(pack('>i', -1))
+        assert str(error.value) == 'invalid length'