Forbidden method invocation: `java.net.URL#<init>(java.lang.String,java.lang.String,int,java.lang.String,java.net.URLStreamHandler)` [Deprecated in Java 21]

[Pankraz76]

• Issue #17487: Add Rewrite:UpgradeToJava21 checkstyle/checkstyle#17789

What version of OpenRewrite are you using?

I am using

• OpenRewrite v1.2.3
• Maven/Gradle plugin v1.2.3
• rewrite-module v1.2.3

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<rewrite-migrate-java.version>3.17.0</rewrite-migrate-java.version>

What is the smallest, simplest way to reproduce the problem?

        final URL url = new URL("test", null, 0, "", new URLStreamHandler() {
            @Override
            protected URLConnection openConnection(URL u) {
                return urlConnection;
            }
        });

What did you expect to see?

        final URL url = new URL("test", null, 0, "", new URLStreamHandler() {
            @Override
            protected URLConnection openConnection(URL u) {
                return urlConnection;
            }
        });

What did you see instead?

        final URL url = URL.of(new URI("test:///"), new URLStreamHandler() {
            @Override
            protected URLConnection openConnection(URL u) {
                return urlConnection;
            }
        });

What is the full stack trace of any errors you encountered?

stacktrace output here

Are you interested in contributing a fix to OpenRewrite?

[Pankraz76]

same for:

[ERROR] Forbidden method invocation: java.net.URL#(java.lang.String) [Deprecated in Java 21]

also not bumping the maven version had to resolve to manually:

${java.version}

<java.version>21</java.version>

[timtebeek]

Thanks for the report! For simplicity this case was indeed left out, also because we did not anticipate a lot of use. Welcome to provide the recipe to fill in this gap.

[Pankraz76]

same same for this guy.

• https://github.com/checkstyle/checkstyle/blob/9f0bf45db1713f6d76fb48acb7d9a8ef1d50b795/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java#L541
• https://github.com/checkstyle/checkstyle/blob/9f0bf45db1713f6d76fb48acb7d9a8ef1d50b795/config/rewrite.yml#L22

private boolean isCheckMatch(TreeWalkerAuditEvent event) {
    final Matcher checkMatcher = tagCheckRegexp.matcher(event.getSourceName());
    return checkMatcher.find();
}