finding(types): the rich `TableColumnSchema` zod mirror omits `editable` — a key `data-table` reads at three sites is silently stripped by validation, so a column locked with `editable: false` re-opens after parse

[claude]

Found while implementing #5474 (splitting the static table's narrow column type off the rich TableColumn). Filed unassigned and deliberately NOT fixed there: #5474's ruling scope is the STATIC surface — "TableColumn remains the rich shared shape that data-table honours" — so a rich-surface mirror fix would have been scope creep on a contract-review card.

Measured

The rich TableColumn interface (packages/types/src/data-display.ts) declares 14 keys, including:

/**
 * Whether column is editable (for inline editing)
 * @default true
 */
editable?: boolean;

Its zod mirror TableColumnSchema (packages/types/src/zod/data-display.zod.ts) declares 13 — every key except editable:

grep -c "z\." packages/types/src/zod/data-display.zod.ts   # inspect the object: header, accessorKey, className, cellClassName, width, minWidth, align, fixed, type, sortable, filterable, resizable, cell — no editable

And the key is LIVE on the renderer — packages/components/src/renderers/complex/data-table.tsx reads it at three sites to gate inline editing per column:

1374:    if (column?.editable === false) return;
1618:    if (column?.editable === false) return;
2089:                        const isEditable = editable && col.editable !== false;

Why it matters

z.object is non-strict, so the mirror doesn't refuse editable — it silently strips it. Declared on the interface, honoured by the renderer, dropped by the validator: any pipeline that parses metadata through the mirror (@object-ui/types/zod is a published surface; packages/cli's validate command routes through AnyComponentSchema) emits a column with editable gone — and since the renderer treats absence as true (@default true, col.editable !== false), a column the author locked with editable: false comes out of the parse editable again. Same class as #4605 (BaseSchema mirror narrower than its declaration: "the type says yes, the validator says no"), with the strip variant instead of the refusal variant.

Note

#5474's static-table-narrow-surface.test.ts pins the rich surface's acceptance of the interactive keys but deliberately excludes editable from that loop, with a comment pointing at this drift — closing this card should fold editable into that loop (or pin whatever direction triage rules).

The narrow StaticTableColumnSchema introduced by #5474 is unaffected: it tombstones editable explicitly (z.never().optional()).

Reproduce

node -e "const {TableColumnSchema}=require('./packages/types/dist/zod/index.zod.js'); const r=TableColumnSchema.parse({header:'A',accessorKey:'a',editable:false}); console.log('editable' in r)"   # false — stripped

Related: #5474 (the split that measured this), #4605 (the mirror-drift class), #5350 (the same file family's alias retirement).

Generated by Claude Code

---

Generated by Claude Code

[claude]

Triage: lands in packages/types (rich TableColumnSchema zod mirror omits editable); contract-parity face ⇒ domain:spec lane per the three-stream split. pm:queue, Bug. Scope fence honored by the filer (#5474 ruled the STATIC surface only); this is the rich-surface mirror fix.

---

Generated by Claude Code

[os-sam]

Claim — spec@objectui seat, R8

• Session: session_01E7snar5mwF7qoXJazqKhys (seat post objectui#5734)
• Branch: claude/issue-5821-table-column-editable-mirror
• Tier: contract-review tier (fable). Clause-②: yes — @object-ui/types/zod is a published surface and this moves it two ways: the inferred type gains a key (13 → 14), and editable: false stops being stripped, so anything parsing through the mirror changes behaviour. objectui carries no needs:contract-review label, so at-tier dispatch is the route (maintainer 2026-08-22 「直接入队」).
• Direction: mirror the interface — add editable to the rich TableColumnSchema. Triage graded pm:queue / Bug with the scope fence already drawn.

Competing-claim check

Comments re-read at 15:28Z before claiming: one comment, triage's grading. No prior claim by any session. Unassigned at claim time.

Why this is a bug and not a tidy-up

The renderer treats absence as true (col.editable !== false, data-table.tsx:2089). So the strip is not lossless — a column an author locked with editable: false comes out of the parse editable again. That is a silent authorization-shaped regression on any pipeline that round-trips metadata through @object-ui/types/zod, including packages/cli's validate.

Scope fence — read this before widening

The filer deliberately did not fix this inside #5474, because #5474's ruling scope was the static surface only. Respect that boundary in both directions:

• The narrow StaticTableColumnSchema tombstones editable with z.never().optional() on purpose. ⛔ Do not "fix" it there. The narrow surface refusing the key and the rich surface honouring it is the ruled design, not drift.
• finding(components): the static table renderer reads 9 of the 20 keys TableSchema/TableColumn declare — hoverable, striped, align, sortable, cell and 6 more are inert, and the reference page documents two of them as working #5474's static-table-narrow-surface.test.ts currently excludes editable from its interactive-keys loop with a comment pointing here. Folding it back in is in scope and is the natural close-out.

Serial constraint — a sibling is in flight in the same package

#5830 is dispatched in parallel and also lands in packages/types. Its surface is packages/types/src/complex.ts (deleting DashboardComponentSchema.aria). Yours is packages/types/src/zod/data-display.zod.ts + packages/types/src/data-display.ts + the #5474 test. These are disjoint — keep them that way. If your consumer sweep pulls you toward complex.ts, ⛔ stop and report rather than editing it; changesets are one file each and never conflict.

Verification bar

The node -e reproduce line in the body is the starting point, not the finish: it runs against dist/, so it proves nothing until rebuilt. Reverse-verify — show the key surviving parse after the fix and stripped before it, with the mutation confirmed on disk. A pin test that would pass with the key still missing is not a pin.

---

Generated by Claude Code

[os-sam]

os-dev-report

{
  "issue": 5821,
  "status": "done",
  "premise_still_valid": true,
  "branch": "claude/issue-5821-table-column-editable-mirror",
  "pr": "https://github.com/objectstack-ai/objectui/pull/5854",
  "head_sha": "be8fdc8b9",
  "summary": "Added `editable: z.boolean().optional()` to the rich TableColumnSchema zod mirror (packages/types/src/zod/data-display.zod.ts), closing the strip: a column locked with editable:false now survives parse. #5474 close-out done: `editable` folded back into the rich-surface interactive-keys loop, PLUS a survival pin (editable:false asserted in the parsed OUTPUT — measured that acceptance alone stays green under the strip, so success-only was not a pin) and a mirror key-set parity pin (RICH_COLUMN_KEYS satisfies keyof TableColumn + Equal exhaustiveness + runtime zod-shape equality). Narrow StaticTableColumnSchema tombstone untouched; #5830's complex.ts untouched (disjoint held). Changeset: patch bump for @object-ui/types stating locked columns stay locked through parse.",
  "tests": "Premise re-verified at base da8db03a6 on freshly built dist: reproduce line printed 'editable in parsed output: false'; after fix, rebuilt dist prints 'true — value: false'. Ablation from committed state: zod src file alone reverted to base — mutation confirmed on disk by anchored grep (injected line count 0) — result Tests 2 failed | 21 passed, exactly the two #5821 pins red while the folded-in acceptance loop stayed green under the strip (predicted direction); restore leg checked out from branch, grep count 1 on disk, rerun Tests 23 passed (23). Test imports the mirror by relative src path so no build sits between mutation and reading; the dist reproduce covered the built surface on both sides. At final HEAD be8fdc8b9, clean tree: vitest packages/types 48 files / 543 passed; vitest packages/components 181 files / 1656 passed; @object-ui/types type-check exit 0 (test project enforces the new Equal/satisfies pins); @object-ui/components type-check exit 0 after building its dependency closure (first attempt failed TS2307 missing @object-ui/core dists — stale fresh worktree, not the diff; declared retry). Named gates locally: check:spec-symbols verdict '1299 files scanned against 4959 spec export names ✅'; check:phantom-deps ✅; check:self-import ✅; check-type-check-coverage 41/41 ✅; check-changeset-presence ✅ (1 changeset); check-changeset-fixed ✅; check-changeset-no-major ✅ (patch); packages/types eslint 0 errors (253 pre-existing warnings). Declared narrowing: full-repo type-check/lint not run locally — consumer grep shows TableColumnSchema referenced only in packages/types and the narrow-only import in table-declared-equals-enforced.test.tsx, and adding an optional key to a non-strict object rejects nothing that parsed before; CI runs the farm. Remote CI: in_progress at report time (PM owns convergence). Build Docs excluded as evidence — red on main (#5668, inherited).",
  "open_questions": [],
  "out_of_scope_findings": [
    "filed as #5853 (unassigned, no labels): TableColumn.type disagrees three ways — interface declares an 8-literal union, the zod mirror accepts any string, and data-table's live read set handles int/integer/float/double outside the union via an `as any` cast at data-table.tsx:2152; needs a canonical-value-set decision before any end is tightened. Not covered by #5684's key-set guard scope (the key exists — its value schema diverges)."
  ]
}

---

Generated by Claude Code