[Utilities] fix ProductOfSets to handle zero-dimensional rows#3022
Open
odow wants to merge 5 commits into
Open
[Utilities] fix ProductOfSets to handle zero-dimensional rows#3022odow wants to merge 5 commits into
odow wants to merge 5 commits into
Conversation
Member
Author
|
Okay, I'm happy with this. It's just simpler all round. It now has one |
odow
commented
Jul 8, 2026
| VAF = MOI.VectorAffineFunction{Float64} | ||
| indices = MOI.get(sets, MOI.ListOfConstraintIndices{VAF,S}()) | ||
| @test indices == MOI.ConstraintIndex{VAF,S}.([1, 3, 6, 8]) | ||
| @test indices == MOI.ConstraintIndex{VAF,S}.([1, 2, 3, 4]) |
Member
Author
There was a problem hiding this comment.
The downside is that you might argue this is breaking, because we change the constraint indices. But I don't think we ever document that the index values are part of the public API. We might re-order them in any way. They just need to make sure that we iterate over them in the order that they were added (within a constraint type).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3019