From 562e2ed42eb119db5e0c798f02ed7ccad3b304be Mon Sep 17 00:00:00 2001 From: agrasth Date: Mon, 21 Sep 2026 12:48:27 +0530 Subject: [PATCH 1/3] Add huggingface_hub version matrix to HuggingFace-Tests CI Pinning to 1.19.0 alone never exercises the strict RepoUrl/parse_hf_uri parsing (PR #4324, landed in 1.20.0) against Artifactory's commitUrl. Add 1.20.0 and 1.29.0 to the matrix as non-blocking (continue-on-error) canary jobs - they're expected to fail until jfrog/jfrog-cli-artifactory#548 merges and this repo's go.mod is bumped to pick up that fix, at which point they should be flipped back to gating. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/huggingfaceTests.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/huggingfaceTests.yml b/.github/workflows/huggingfaceTests.yml index a6989ba71..eefd147c5 100644 --- a/.github/workflows/huggingfaceTests.yml +++ b/.github/workflows/huggingfaceTests.yml @@ -8,7 +8,7 @@ permissions: contents: read jobs: HuggingFace-Tests: - name: HuggingFace tests (${{ matrix.os.name }}) + name: HuggingFace tests (${{ matrix.os.name }}, huggingface_hub ${{ matrix.hf_version }}) strategy: fail-fast: false matrix: @@ -19,7 +19,15 @@ jobs: version: 2022 - name: macos version: 14 + # 1.19.0: last version before the breaking change and the one this repo's + # go.mod dependency on jfrog-cli-artifactory currently supports. 1.20.0/1.29.0: + # exercise huggingface_hub's stricter RepoUrl/parse_hf_uri parsing (PR #4324) + # against Artifactory's commitUrl. Expected to fail until + # jfrog/jfrog-cli-artifactory#548 merges and this repo's go.mod is bumped to + # pick it up - see continue-on-error below. + hf_version: ['1.19.0', '1.20.0', '1.29.0'] runs-on: ${{ matrix.os.name }}-${{ matrix.os.version }} + continue-on-error: ${{ matrix.hf_version != '1.19.0' }} steps: - name: Skip macOS - JGC-413 if: matrix.os.name == 'macos' @@ -55,10 +63,7 @@ jobs: - name: Install HuggingFace Library if: matrix.os.name != 'macos' run: | - # Pin to 1.19.0: huggingface_hub 1.20.0 made RepoUrl parse the commit - # response's commitUrl field strictly as an hf:// URI (PR #4324), which - # breaks against Artifactory's placeholder commitUrl value. - pip install "huggingface_hub==1.19.0" + pip install "huggingface_hub==${{ matrix.hf_version }}" shell: bash - name: Debug macOS Environment and Set Timeout From 9bbc648f335d435b0dd7b4432a29d406851a0d56 Mon Sep 17 00:00:00 2001 From: agrasth Date: Mon, 21 Sep 2026 15:40:05 +0530 Subject: [PATCH 2/3] Bump jfrog-cli-artifactory dependency to pick up huggingface_hub 1.29.0 fix jfrog/jfrog-cli-artifactory#548 merged (91bb546), fixing HfUriError handling for huggingface_hub >= 1.20.0. Co-Authored-By: Claude Sonnet 5 --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 596de8d57..96b17e30d 100644 --- a/go.mod +++ b/go.mod @@ -22,7 +22,7 @@ require ( github.com/jfrog/build-info-go v1.13.1-0.20260916133330-b238519a26ff github.com/jfrog/gofrog v1.7.7 github.com/jfrog/jfrog-cli-application v1.0.2-0.20260820134442-c8629258ff3a - github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260916135713-bed01c2d7f80 + github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260921100410-91bb546a78fb github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260909093400-32a7208a18bd github.com/jfrog/jfrog-cli-evidence v0.11.1-0.20260824063609-79b735ec565e github.com/jfrog/jfrog-cli-platform-services v1.10.1-0.20260618062042-6053ab368cab diff --git a/go.sum b/go.sum index 0a8f63a69..ca2a85d65 100644 --- a/go.sum +++ b/go.sum @@ -402,8 +402,8 @@ github.com/jfrog/jfrog-apps-config v1.0.1 h1:mtv6k7g8A8BVhlHGlSveapqf4mJfonwvXYL github.com/jfrog/jfrog-apps-config v1.0.1/go.mod h1:8AIIr1oY9JuH5dylz2S6f8Ym2MaadPLR6noCBO4C22w= github.com/jfrog/jfrog-cli-application v1.0.2-0.20260820134442-c8629258ff3a h1:7GhcPfi+k9oOAJdCsKWjymnqH0e7DQZ1soVhbneYnGY= github.com/jfrog/jfrog-cli-application v1.0.2-0.20260820134442-c8629258ff3a/go.mod h1:p8yLtbmCxxQucIbLZKnWu0F+EDtj6NLXbRQCEK/nb6o= -github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260916135713-bed01c2d7f80 h1:/nW3wAWddLmNGL41UNbBWxmrTIsmvcUeotNxf2TOWCc= -github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260916135713-bed01c2d7f80/go.mod h1:LiwWRqnUcVP8ia7109NJveSEQX62uOh1ItwdoDJusFY= +github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260921100410-91bb546a78fb h1:REebsVGc3EGBZZeWv7MWoqIfozCSMM8xR4NSDlQgna4= +github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260921100410-91bb546a78fb/go.mod h1:LiwWRqnUcVP8ia7109NJveSEQX62uOh1ItwdoDJusFY= github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260909093400-32a7208a18bd h1:tfC6CtOpqWoU/1V4ymBL0GnhM2kbq5JTGSaAk9eOybg= github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260909093400-32a7208a18bd/go.mod h1:SwV+DNLBnWLxBeNeZpJk+xxAbqJ8ywq1va56up+AGu4= github.com/jfrog/jfrog-cli-evidence v0.11.1-0.20260824063609-79b735ec565e h1:+QYbewvK+PZKbfPpxYmy0bewhqMFtJPk/tUbCICjf8U= From 199c10afaf39d2e4637dcbaf304f05f9763858e6 Mon Sep 17 00:00:00 2001 From: agrasth Date: Mon, 21 Sep 2026 16:26:09 +0530 Subject: [PATCH 3/3] Remove continue-on-error now that huggingface_hub 1.20.0/1.29.0 pass Confirmed via manual workflow run against the bumped jfrog-cli-artifactory dependency: https://github.com/jfrog/jfrog-cli/actions/runs/35587298987 Co-Authored-By: Claude Sonnet 5 --- .github/workflows/huggingfaceTests.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/huggingfaceTests.yml b/.github/workflows/huggingfaceTests.yml index eefd147c5..61018882e 100644 --- a/.github/workflows/huggingfaceTests.yml +++ b/.github/workflows/huggingfaceTests.yml @@ -19,15 +19,11 @@ jobs: version: 2022 - name: macos version: 14 - # 1.19.0: last version before the breaking change and the one this repo's - # go.mod dependency on jfrog-cli-artifactory currently supports. 1.20.0/1.29.0: - # exercise huggingface_hub's stricter RepoUrl/parse_hf_uri parsing (PR #4324) - # against Artifactory's commitUrl. Expected to fail until - # jfrog/jfrog-cli-artifactory#548 merges and this repo's go.mod is bumped to - # pick it up - see continue-on-error below. + # 1.20.0/1.29.0 exercise huggingface_hub's stricter RepoUrl/parse_hf_uri + # parsing (PR #4324) against Artifactory's commitUrl, fixed in + # jfrog/jfrog-cli-artifactory#548 (this repo's go.mod is bumped to include it). hf_version: ['1.19.0', '1.20.0', '1.29.0'] runs-on: ${{ matrix.os.name }}-${{ matrix.os.version }} - continue-on-error: ${{ matrix.hf_version != '1.19.0' }} steps: - name: Skip macOS - JGC-413 if: matrix.os.name == 'macos'