From 9b70026b7fca72a191e731627a53b8a2f0279d06 Mon Sep 17 00:00:00 2001 From: Fabian Schuetze Date: Tue, 1 Jul 2025 17:53:06 +0200 Subject: [PATCH 1/3] don't exit silently in case of wrong name of subroutine --- apps/linear_algebra/benchmarks/halide_benchmarks.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp index e150fa840253..2fd17fabb053 100644 --- a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp +++ b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp @@ -14,7 +14,6 @@ #include "clock.h" #include "halide_blas.h" #include "macros.h" -#include #include #include #include @@ -82,6 +81,9 @@ struct BenchmarksBase { bench_gemm_transB(size); } else if (benchmark == "gemm_transAB") { bench_gemm_transAB(size); + } else { + std::cout << "subroutine: <" << benchmark << "> not know\n"; + return; } } From 8a921df771508513482ac5bc0f226519c71086c0 Mon Sep 17 00:00:00 2001 From: Fabian Schuetze Date: Tue, 1 Jul 2025 17:55:48 +0200 Subject: [PATCH 2/3] spelling --- apps/linear_algebra/benchmarks/halide_benchmarks.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp index 2fd17fabb053..6cca88b417e1 100644 --- a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp +++ b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp @@ -82,7 +82,7 @@ struct BenchmarksBase { } else if (benchmark == "gemm_transAB") { bench_gemm_transAB(size); } else { - std::cout << "subroutine: <" << benchmark << "> not know\n"; + std::cout << "subroutine: <" << benchmark << "> not known\n"; return; } } From b9394e228b744cd2f623cad09a642dab2287302e Mon Sep 17 00:00:00 2001 From: Alex Reinking Date: Sun, 29 Mar 2026 18:07:03 -0400 Subject: [PATCH 3/3] Print to stderr and exit --- apps/linear_algebra/benchmarks/halide_benchmarks.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp index 6cca88b417e1..528f8ed9ea70 100644 --- a/apps/linear_algebra/benchmarks/halide_benchmarks.cpp +++ b/apps/linear_algebra/benchmarks/halide_benchmarks.cpp @@ -14,6 +14,7 @@ #include "clock.h" #include "halide_blas.h" #include "macros.h" +#include #include #include #include @@ -82,8 +83,8 @@ struct BenchmarksBase { } else if (benchmark == "gemm_transAB") { bench_gemm_transAB(size); } else { - std::cout << "subroutine: <" << benchmark << "> not known\n"; - return; + std::cerr << "subroutine: <" << benchmark << "> not known\n"; + std::exit(1); } } @@ -161,8 +162,8 @@ struct BenchmarksDouble : public BenchmarksBase { int main(int argc, char *argv[]) { if (argc != 3) { - std::cout << "USAGE: halide_benchmarks \n"; - return 0; + std::cerr << "USAGE: halide_benchmarks \n"; + return 1; } std::string subroutine = argv[1]; @@ -174,6 +175,9 @@ int main(int argc, char *argv[]) { BenchmarksFloat("Halide").run(subroutine, size); } else if (type == 'd') { BenchmarksDouble("Halide").run(subroutine, size); + } else { + std::cerr << "type: '" << type << "' not known. Expected 's' or 'd'.\n"; + return 1; } return 0;