Skip to content

Commit afbbabf

Browse files
committed
review
1 parent 1268b32 commit afbbabf

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

‎test/test_assure_directory.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
@pytest.fixture
1010
def directory_fixture(monkeypatch):
11-
with writable_fixture("assure-directory.sh") as temporary:
11+
with writable_fixture("empty.sh") as temporary:
1212
directory = temporary.path().resolve()
1313
with monkeypatch.context() as context:
1414
context.chdir(directory)
@@ -32,11 +32,13 @@ def test_nested_file_creates_only_missing_parent_directories(directory_fixture,
3232

3333
@pytest.mark.parametrize("path_type", [str, Path])
3434
def test_existing_directory_is_unchanged(directory_fixture, path_type):
35+
(directory_fixture / "existing").mkdir()
3536
assert assure_directory_exists(path_type("existing")) is False
3637

3738

3839
@pytest.mark.parametrize("path_type", [str, Path])
3940
def test_file_cannot_be_used_as_parent_directory(directory_fixture, path_type):
41+
(directory_fixture / "blocked").write_text("occupied\n")
4042
with pytest.raises(FileExistsError):
4143
assure_directory_exists(path_type("blocked/notes.txt"), is_file=True)
4244
assert (directory_fixture / "blocked").read_text() == "occupied\n"

‎tests/fixtures/assure-directory.sh‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)