Address review feedback about config lookup

Review feedback: Git treats core.hooksPath case-insensitively even though GitConfigParser preserves option casing, and the default-path test can inherit a host-level hooksPath.

Find the configured option with a case-insensitive scan of the effective core section, and spell the regression setting with mixed case. Scope the legacy fallback test to repository configuration so system and user settings cannot affect it.

Author: codex

git/index/fun.py

@@ -67,11 +67,13 @@ def hook_path(name: str, git_dir: PathLike) -> str:
 def _commit_hook_path(name: str, index: "IndexFile") -> str:
     """:return: path to the named commit hook, respecting Git's core.hooksPath."""
     with index.repo.config_reader() as config:
-        if not config.has_option("core", "hooksPath"):
-            return hook_path(name, index.repo.git_dir)
-        hooks_dir = osp.expanduser(config.get("core", "hooksPath"))
+        core_items = config.items("core") if config.has_section("core") else []
+        hooks_dir = next((value for option, value in reversed(core_items) if option.lower() == "hookspath"), None)
 
-    return osp.abspath(osp.join(index.repo.working_dir, hooks_dir, name))
+    if hooks_dir is None:
+        return hook_path(name, index.repo.git_dir)
+
+    return osp.abspath(osp.join(index.repo.working_dir, osp.expanduser(hooks_dir), name))
 
 
 def _has_file_extension(path: str) -> str:

test/test_index.py

@@ -1099,8 +1099,9 @@ class Mocked:
     def test_run_commit_hook(self, rw_repo):
         index = rw_repo.index
         _make_hook(index.repo.git_dir, "fake-hook", "echo 'ran fake hook' >output.txt")
-        with mock.patch.object(Git, "execute", side_effect=AssertionError("hook lookup must not run git")):
-            run_commit_hook("fake-hook", index)
+        with mock.patch.object(Repo, "config_level", ("repository",)):
+            with mock.patch.object(Git, "execute", side_effect=AssertionError("hook lookup must not run git")):
+                run_commit_hook("fake-hook", index)
         output = Path(rw_repo.git_dir, "output.txt").read_text(encoding="utf-8")
         self.assertEqual(output, "ran fake hook\n")
 
@@ -1198,7 +1199,7 @@ def test_pre_commit_hook_respects_core_hooks_path(self, rw_repo):
         os.chmod(hp, 0o744)
 
         with index.repo.config_writer() as writer:
-            writer.set_value("core", "hooksPath", "custom-hooks")
+            writer.set_value("core", "HoOkSpAtH", "custom-hooks")
 
         index.commit("This should run the custom hook")
         output = Path(rw_repo.working_dir, "custom-hook-output.txt").read_text(encoding="utf-8")