improve: threat detection engine error template with progressive disclosure - #49497
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…losure Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| const reasonText = getDetectionReasonText(detectionReason); | ||
| if (isToolingFailureReason(detectionReason)) { | ||
| return `> [!WARNING]\n> threat detection engine error\n> The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| return `> [!WARNING]\n> **Threat Detection Engine Failure** — The analysis engine could not complete. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>What happened</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; |
There was a problem hiding this comment.
@copilot move to template file in actions/setup/md and use render template file helpers to render.
There was a problem hiding this comment.
Done. Created prompt_file_helpers.cjs with getPromptPath (with ../md fallback), renderTemplate, and renderTemplateFromFile. Updated generate_footer.cjs to import from this new module instead of using the inline local helpers. messages_core.cjs now also imports and re-exports from prompt_file_helpers.cjs for backward compatibility. Commit: a738c3c
| return `> [!WARNING]\n> threat detection engine error\n> The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| return `> [!WARNING]\n> **Threat Detection Engine Failure** — The analysis engine could not complete. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>What happened</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| } | ||
| return `> [!CAUTION]\n> agentic threat detected\n> Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; |
There was a problem hiding this comment.
@copilot move to template file in actions/setup/md and use render template file helpers to render.
There was a problem hiding this comment.
Done in the same commit. The threat_detection_caution.md template is rendered via renderTemplateFromFile(getPromptPath(...), context) from the new prompt_file_helpers.cjs module. Commit: a738c3c
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the implementation label and has 0 new lines of code in business logic directories (threshold: 100). |
There was a problem hiding this comment.
Pull request overview
Improves threat-detection failure messages with clearer titles and progressive disclosure.
Changes:
- Clarifies tooling-failure warnings.
- Collapses run details behind descriptive summaries.
- Updates assertions and refreshes one unrelated workflow lock file.
Show a summary per file
| File | Description |
|---|---|
actions/setup/md/detection_runs_comment.md |
Adds summary text and collapsible details. |
actions/setup/js/messages.test.cjs |
Updates warning-title assertion. |
actions/setup/js/messages_run_status.cjs |
Revises configured warning output. |
actions/setup/js/generate_footer.test.cjs |
Updates footer assertions. |
actions/setup/js/generate_footer.cjs |
Revises footer warning output. |
.github/workflows/daily-byok-ollama-test.lock.yml |
Refreshes unrelated runtime configuration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 4
- Review effort level: Balanced
| @@ -1,7 +1,14 @@ | |||
| ### {workflow_name} | |||
|
|
|||
| The threat detection engine could not complete analysis for this run. This is a tooling failure, not a security finding. | |||
|
|
||
| expect(result).toContain("> [!WARNING]"); | ||
| expect(result).toContain("threat detection engine error"); | ||
| expect(result).toContain("Threat Detection Engine Failure"); |
|
|
||
| expect(result).toContain("> [!WARNING]"); | ||
| expect(result).toContain("threat detection engine error"); | ||
| expect(result).toContain("Threat Detection Engine Failure"); |
| (umask 177 && touch /tmp/gh-aw/threat-detection/detection.log) | ||
| GH_AW_MAX_AI_CREDITS="${{ vars.GH_AW_DEFAULT_DETECTION_MAX_AI_CREDITS || '400' }}" | ||
| printf '%s\n' "{\"\$schema\":\"https://github.com/github/gh-aw-firewall/releases/download/v0.27.43/awf-config.schema.json\",\"network\":{\"allowDomains\":[\"api.business.githubcopilot.com\",\"api.enterprise.githubcopilot.com\",\"api.github.com\",\"api.githubcopilot.com\",\"api.individual.githubcopilot.com\",\"github.com\",\"host.docker.internal\",\"raw.githubusercontent.com\",\"registry.npmjs.org\",\"telemetry.enterprise.githubcopilot.com\"]},\"apiProxy\":{\"enabled\":true,\"enableTokenSteering\":true,\"maxRuns\":500,\"maxAiCredits\":${GH_AW_MAX_AI_CREDITS},\"maxCacheMisses\":5,\"targets\":{\"copilot\":{\"host\":\"host.docker.internal:11434\"}}},\"container\":{\"imageTag\":\"0.27.43,squid=sha256:26be5e0b8c8f4c41c8a59126b29bb5d80b07253597472ded2a16bdd75abcbf9d,agent=sha256:04e2d1987a565000a8f114b89d806ae7a3864dd4f944be65275b28c93d8690e6,api-proxy=sha256:d85f57975af5ea23af4996e41ed73fbc8f5b4a47402472bfe82e508f352cb0c1,cli-proxy=sha256:65c45ea2967984d0024f3df61bc71335658a77ede96c8d9665da7a5f33a795ab\"},\"logging\":{\"proxyLogsDir\":\"/tmp/gh-aw/sandbox/firewall/logs\",\"auditDir\":\"/tmp/gh-aw/sandbox/firewall/audit\"}}" > "${RUNNER_TEMP}/gh-aw/awf-config.json" | ||
| printf '%s\n' "{\"\$schema\":\"https://github.com/github/gh-aw-firewall/releases/download/v0.27.43/awf-config.schema.json\",\"network\":{\"allowDomains\":[\"api.business.githubcopilot.com\",\"api.enterprise.githubcopilot.com\",\"api.github.com\",\"api.githubcopilot.com\",\"api.individual.githubcopilot.com\",\"github.com\",\"host.docker.internal\",\"raw.githubusercontent.com\",\"registry.npmjs.org\",\"telemetry.enterprise.githubcopilot.com\"]},\"apiProxy\":{\"enabled\":true,\"enableTokenSteering\":true,\"maxRuns\":500,\"maxAiCredits\":${GH_AW_MAX_AI_CREDITS},\"maxCacheMisses\":5,\"defaultAiCreditsPricing\":{\"input\":0.000001,\"output\":0.000001},\"targets\":{\"copilot\":{\"host\":\"host.docker.internal:11434\"}},\"models\":{\"agent\":[\"sonnet-6x\",\"gpt-5.4\",\"gpt-5.5\",\"gpt-5.6\",\"gpt-5.3\",\"gemini-pro\",\"any\"],\"antigravity\":[\"copilot/antigravity*\",\"google/antigravity*\",\"gemini/antigravity*\"],\"any\":[\"copilot/*\",\"anthropic/*\",\"openai/*\",\"google/*\",\"gemini/*\"],\"auto\":[\"copilot/auto\",\"large\"],\"claude\":[\"agent\"],\"codex\":[\"agent\"],\"coding\":[\"copilot/gpt-5*codex*\",\"openai/gpt-5*codex*\",\"gpt-5-codex\",\"kimi\"],\"computer-use\":[\"copilot/*computer-use*\",\"google/*computer-use*\",\"gemini/*computer-use*\",\"openai/*computer-use*\"],\"copilot\":[\"agent\"],\"deep-research\":[\"copilot/deep-research*\",\"copilot/o3-deep-research*\",\"copilot/o4-mini-deep-research*\",\"google/deep-research*\",\"gemini/deep-research*\",\"openai/o3-deep-research*\",\"openai/o4-mini-deep-research*\"],\"fable\":[\"copilot/*fable*\",\"anthropic/*fable*\"],\"gemini\":[\"agent\"],\"gemini-3-flash\":[\"copilot/gemini-3*flash*\",\"google/gemini-3*flash*\",\"gemini/gemini-3*flash*\"],\"gemini-3-pro\":[\"copilot/gemini-3*pro*\",\"google/gemini-3*pro*\",\"google/nano-banana*\",\"gemini/gemini-3*pro*\"],\"gemini-3.1-flash\":[\"copilot/gemini-3.1*flash*\",\"google/gemini-3.1*flash*\",\"gemini/gemini-3.1*flash*\"],\"gemini-3.1-pro\":[\"copilot/gemini-3.1*pro*\",\"google/gemini-3.1*pro*\",\"gemini/gemini-3.1*pro*\"],\"gemini-3.5-flash\":[\"copilot/gemini-3.5*flash*\",\"google/gemini-3.5*flash*\",\"gemini/gemini-3.5*flash*\"],\"gemini-3.6-flash\":[\"copilot/gemini-3.6*flash*\",\"google/gemini-3.6*flash*\",\"gemini/gemini-3.6*flash*\"],\"gemini-flash\":[\"copilot/gemini-*flash*\",\"google/gemini-*flash*\",\"gemini/gemini-*flash*\"],\"gemini-flash-lite\":[\"copilot/gemini-*flash*lite*\",\"google/gemini-*flash*lite*\",\"gemini/gemini-*flash*lite*\"],\"gemini-omni\":[\"copilot/gemini-omni*\",\"google/gemini-omni*\",\"gemini/gemini-omni*\"],\"gemini-pro\":[\"copilot/gemini-*pro*\",\"google/gemini-*pro*\",\"gemini/gemini-*pro*\"],\"gemma\":[\"copilot/gemma*\",\"google/gemma*\",\"gemini/gemma*\"],\"gpt-5\":[\"copilot/gpt-5*\",\"openai/gpt-5*\"],\"gpt-5-codex\":[\"copilot/gpt-5*codex*\",\"openai/gpt-5*codex*\"],\"gpt-5-mini\":[\"copilot/gpt-5*mini*\",\"openai/gpt-5*mini*\"],\"gpt-5-nano\":[\"copilot/gpt-5*nano*\",\"openai/gpt-5*nano*\"],\"gpt-5-pro\":[\"copilot/gpt-5*pro*\",\"openai/gpt-5*pro*\"],\"gpt-5.1\":[\"copilot/gpt-5.1*\",\"openai/gpt-5.1*\"],\"gpt-5.2\":[\"copilot/gpt-5.2*\",\"openai/gpt-5.2*\"],\"gpt-5.3\":[\"copilot/gpt-5.3*\",\"openai/gpt-5.3*\"],\"gpt-5.4\":[\"copilot/gpt-5.4*\",\"openai/gpt-5.4*\"],\"gpt-5.5\":[\"copilot/gpt-5.5*\",\"openai/gpt-5.5*\"],\"gpt-5.6\":[\"copilot/gpt-5.6*\",\"openai/gpt-5.6*\"],\"grok\":[\"copilot/*grok*\",\"openai/*grok*\"],\"haiku\":[\"copilot/*haiku*\",\"anthropic/*haiku*\"],\"image-generation\":[\"copilot/gpt-image*\",\"openai/gpt-image*\",\"openai/chatgpt-image*\",\"copilot/gemini-*image*\",\"google/gemini-*image*\",\"gemini/gemini-*image*\",\"google/imagen*\"],\"kimi\":[\"copilot/kimi*\",\"openai/kimi*\"],\"kiwi\":[\"copilot/kiwi*\",\"openai/kiwi*\"],\"large\":[\"sonnet\",\"gpt-5-pro\",\"gpt-5\",\"gemini-pro\"],\"lyria\":[\"google/lyria*\",\"gemini/lyria*\",\"copilot/lyria*\"],\"mai-code\":[\"copilot/MAI-Code*\",\"copilot/mai-code*\",\"openai/MAI-Code*\"],\"mai-code-1-flash-picker\":[\"copilot/MAI-Code-1-Flash-picker*\",\"copilot/mai-code-1-flash-picker*\",\"openai/MAI-Code-1-Flash-picker*\"],\"mini\":[\"haiku\",\"gpt-5-mini\",\"gpt-5-nano\",\"gemini-flash-lite\"],\"nano-banana\":[\"copilot/nano-banana*\",\"google/nano-banana*\",\"gemini/nano-banana*\"],\"opus\":[\"copilot/*opus*\",\"anthropic/*opus*\"],\"opusplan\":[\"opus?effort=high\"],\"raptor-mini\":[\"copilot/raptor*\",\"openai/raptor*\"],\"reasoning\":[\"copilot/o1*\",\"copilot/o3*\",\"copilot/o4*\",\"openai/o1*\",\"openai/o3*\",\"openai/o4*\"],\"robotics\":[\"copilot/*robotics*\",\"google/*robotics*\",\"gemini/*robotics*\"],\"small\":[\"mini\"],\"small-agent\":[\"haiku\",\"gpt-5-mini\",\"gemini-flash\"],\"sonnet\":[\"copilot/*sonnet*\",\"anthropic/*sonnet*\"],\"sonnet-6x\":[\"copilot/*sonnet-4.5*\",\"copilot/*sonnet-4.6*\",\"copilot/*sonnet-5*\",\"copilot/*sonnet-4-5-*\",\"anthropic/*sonnet-4-5-*\",\"copilot/*sonnet-4-6*\",\"anthropic/*sonnet-4-6*\",\"anthropic/*sonnet-5*\"],\"summarization\":[\"haiku\",\"gpt-5-mini\",\"gemini-flash-lite\",\"mini\"],\"veo\":[\"google/veo*\",\"gemini/veo*\"],\"vision\":[\"copilot/gemini-*image*\",\"google/gemini-*image*\",\"gemini/gemini-*image*\",\"copilot/gemini-*flash*\",\"google/gemini-*flash*\",\"gemini/gemini-*flash*\"]}},\"container\":{\"imageTag\":\"0.27.43,squid=sha256:26be5e0b8c8f4c41c8a59126b29bb5d80b07253597472ded2a16bdd75abcbf9d,agent=sha256:04e2d1987a565000a8f114b89d806ae7a3864dd4f944be65275b28c93d8690e6,api-proxy=sha256:d85f57975af5ea23af4996e41ed73fbc8f5b4a47402472bfe82e508f352cb0c1,cli-proxy=sha256:65c45ea2967984d0024f3df61bc71335658a77ede96c8d9665da7a5f33a795ab\"},\"logging\":{\"proxyLogsDir\":\"/tmp/gh-aw/sandbox/firewall/logs\",\"auditDir\":\"/tmp/gh-aw/sandbox/firewall/audit\"}}" > "${RUNNER_TEMP}/gh-aw/awf-config.json" |
|
✅ Test Quality Sentinel completed test quality analysis. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — clean improvement, two minor consistency issues.
📋 Key Themes & Highlights
Key Themes
- Naming:
"Threat Detection Engine Failure"is bold, capitalised, and semantically clear — good. - Progressive disclosure: adding an always-visible summary in
detection_runs_comment.mdand collapsing the raw table is a solid UX win. - Consistency gap: the
[!CAUTION]branch in bothgenerate_footer.cjsandmessages_run_status.cjsstill uses<summary>Details</summary>while the[!WARNING]branch now saysWhat happened. Left behind in this pass. - Generic summary: the lead sentence in
detection_runs_comment.mddoes not surface{reason}or{conclusion}, so users still have to expand the block for any actionable context.
Positive Highlights
- ✅ Tests updated to match new copy — no drift between implementation and assertions.
- ✅ Consistent change applied across both
generate_footer.cjsandmessages_run_status.cjs. - ✅
"This is a tooling failure, not a security finding."is an excellent user-calming clarification.
@copilot please address the review comments above.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 27.8 AIC · ⌖ 9.76 AIC · ⊞ 7K
Comment /matt to run again
| @@ -1,7 +1,14 @@ | |||
| ### {workflow_name} | |||
|
|
|||
| The threat detection engine could not complete analysis for this run. This is a tooling failure, not a security finding. | |||
There was a problem hiding this comment.
[/grill-with-docs] The always-visible summary is generic and does not mention the specific failure reason ({reason}), reducing its diagnostic value.
💡 Suggestion
Consider incorporating {reason} or {conclusion} into the lead sentence so readers get a quick signal without expanding the details block:
The threat detection engine could not complete analysis (`{conclusion}`). This is a tooling failure, not a security finding.This keeps progressive disclosure intact while giving an at-a-glance clue.
@copilot please address this.
| return `> [!WARNING]\n> threat detection engine error\n> The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| return `> [!WARNING]\n> **Threat Detection Engine Failure** — The analysis engine could not complete. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>What happened</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| } | ||
| return `> [!CAUTION]\n> agentic threat detected\n> Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; |
There was a problem hiding this comment.
[/grill-with-docs] The [!CAUTION] branch (actual threat detections) still uses <summary>Details</summary>, inconsistent with the What happened label introduced in the [!WARNING] branch.
💡 Suggestion
Apply the same label update to the CAUTION path for consistency:
return `> [!CAUTION]\n> agentic threat detected\n> ...\n>\n> <details>\n> <summary>What happened</summary>\n>\n> ...`;The same applies to the parallel template in messages_run_status.cjs.
@copilot please address this.
🧪 Test Quality Sentinel Report✅ Test Quality Score: 100/100 — Excellent
📊 Metrics (2 tests)
SummaryThese changes update 3 string-literal assertions across 2 existing test functions to match the renamed error title. The tests verify user-visible output text and include both positive ( Verdict
|
There was a problem hiding this comment.
Blocking: this PR does not address the maintainer's own unresolved review comment to move templates to actions/setup/md files.
Themes
- The wording improvements themselves are fine (bolded title, better summary label), but the underlying architectural request from @pelikhan on lines 136/138 of
generate_footer.cjs— extract to a template file and use render helpers — was ignored, even though this same PR proves the pattern works (detection_runs_comment.md). - As a direct consequence, the near-identical warning string is now duplicated across
generate_footer.cjsandmessages_run_status.cjs, and has already drifted in wording from the.mdtemplate touched in the same PR. This is the exact maintenance risk the reviewer was trying to prevent. - The
daily-byok-ollama-test.lock.ymldiff appears to be an unrelated regenerated artifact (models/pricing config) and is out of scope for a wording-only PR; not blocking but worth a note/split.
🔎 Code quality review by PR Code Quality Reviewer · auto · 57.9 AIC · ⌖ 10.9 AIC · ⊞ 7.8K
Comment /review to run again
| const reasonText = getDetectionReasonText(detectionReason); | ||
| if (isToolingFailureReason(detectionReason)) { | ||
| return `> [!WARNING]\n> threat detection engine error\n> The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>Details</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; | ||
| return `> [!WARNING]\n> **Threat Detection Engine Failure** — The analysis engine could not complete. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarker(detectionReason)}\n>\n> <details>\n> <summary>What happened</summary>\n>\n> ${reasonText}\n>\n> Review the [workflow run logs](${runUrl}) for details.\n> </details>`; |
There was a problem hiding this comment.
@pelikhan's explicit review request on this exact line — move to a template file in actions/setup/md and render via existing helpers — was not addressed.
💡 Why this matters
The PR already demonstrates the correct pattern: detection_runs_comment.md was updated to use a proper template file with a <details> block. Yet this near-identical warning string was left as an inline JS template literal here, duplicated again almost verbatim in messages_run_status.cjs (see companion comment). This is exactly the maintenance burden the reviewer flagged: any future wording tweak must now be applied in at least two JS files plus the .md file, and they have already drifted (compare "The analysis engine could not complete" here vs. "The threat detection engine could not complete analysis for this run" in detection_runs_comment.md).
Suggested fix: extract this and the CAUTION variant into actions/setup/md/*.md template files and call the same render-template-file helper used elsewhere, exactly as requested.
| const isEngineError = isToolingFailureReason(ctx.reason); | ||
| if (isEngineError) { | ||
| const defaultTemplate = `> [!WARNING]\n> threat detection engine error\n> The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarkerTemplate()}\n>\n> <details>\n> <summary>Details</summary>\n>\n> {reason_text}\n>\n> Review the [workflow run logs]({run_url}) for details.\n> </details>`; | ||
| const defaultTemplate = `> [!WARNING]\n> **Threat Detection Engine Failure** — The analysis engine could not complete. This is a tooling failure, not a security finding.\n> ${getThreatDetectedMarkerTemplate()}\n>\n> <details>\n> <summary>What happened</summary>\n>\n> {reason_text}\n>\n> Review the [workflow run logs]({run_url}) for details.\n> </details>`; |
There was a problem hiding this comment.
This warning string duplicates generate_footer.cjs line 136 verbatim, and its wording has already drifted from the .md template used elsewhere in this same PR.
💡 Drift risk detail
Compare the three near-identical strings introduced/touched by this PR:
- Here and
generate_footer.cjs: "The analysis engine could not complete." detection_runs_comment.md: "The threat detection engine could not complete analysis for this run."
They already say different things despite describing the exact same failure condition, in the same PR. This confirms the maintainer's concern (unresolved comment on generate_footer.cjs lines 136/138): keeping the template inline instead of a shared .md file makes future edits error-prone — a wording change here is easy to forget to apply in generate_footer.cjs (or vice versa), and the .md copy is already out of sync as a preview of that risk.
There was a problem hiding this comment.
Review: Threat Detection Engine Error Template Improvements
The changes are clean, consistent, and well-tested. The progressive disclosure pattern improves scannability.
Observations:
- Title change to bold
**Threat Detection Engine Failure**is a meaningful UX improvement. - Description tightening is clearer than the original.
<summary>What happened</summary>is more informative than genericDetails.detection_runs_comment.mdnow provides an always-visible context sentence before the collapsible block — good pattern.- Test assertions are updated consistently across both test files.
Note: The .lock.yml change appears to be an unrelated firewall config update (model routing, pricing defaults) bundled into this PR — consider separating it.
Existing review comments already flag the right architectural follow-up: inline template strings in generate_footer.cjs and messages_run_status.cjs should be moved to template files under actions/setup/md/ using render-template helpers, consistent with the detection_runs_comment.md approach. No further blocking issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 15 AIC · ⌖ 7.19 AIC · ⊞ 5.3K
|
Caution agentic threat detected DetailsPotential security threats were detected in the agent output. Review the workflow run logs for details. @copilot quick triage for this PR:
|
…est test setup Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Fixed the failing JS Tests (shard 3/4). The |
PR TriageCategory: feature · Risk: low · Priority: medium · Score: 53/100 (impact 22, urgency 15, quality 16) Recommended action: UX polish for threat-detection error templates (bold titles, clearer disclosure labels). Active review thread (8 comments, 16 review comments). Groups well with other safe-outputs/threat-detection UX PRs for batch review.
|
PR Triage
Cosmetic error-template UX improvement, low risk, no urgency.
|
|
@copilot quick triage for this PR:
|
…ons for progressive disclosure Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
All open items addressed in the latest commit:
This PR is now blocked on maintainer review only — no outstanding automation failures or unaddressed feedback. |
…ure test setup Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed. The |
|
@copilot resolve the merge conflicts on this branch. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. Merged
All 268 workflows recompiled and pre-PR validation passed. |
The threat detection engine error warning used a lowercase, non-bold title ("threat detection engine error") and a generic
<summary>Details</summary>disclosure label, making it hard to scan and understand at a glance.Changes
generate_footer.cjs,messages_run_status.cjs):threat detection engine error→**Threat Detection Engine Failure**; description tightened;<summary>Details</summary>→<summary>What happened</summary>detection_runs_comment.md): adds an always-visible summary sentence up front; moves the raw run details table into a collapsible<details>Run details</details>blockgenerate_footer.test.cjs,messages.test.cjs): assertions updated to match new titleBefore:
After:
Caution
agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.
Details
Potential security threats were detected in the agent output.
Review the workflow run logs for details.
run: https://github.com/github/gh-aw/actions/runs/30692749654