Revert "Add PowerShell dependency to winget manifests"#1548
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts changes from PR #1497 that added PowerShell dependency manipulation to the winget package submission workflow. The revert was triggered by a failing GitHub Actions run (https://github.com/github/copilot-cli/actions/runs/22186218770), restoring the workflow to its simpler, original state where wingetcreate directly submits the package without manual manifest modification.
Changes:
- Removed PowerShell script logic that added Microsoft.PowerShell dependency to installer manifests
- Restored direct
--submitflag to wingetcreate instead of two-step--out+submitprocess
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteveSandersonMS
approved these changes
Feb 19, 2026
SteveSandersonMS
added a commit
that referenced
this pull request
Feb 19, 2026
Re-applies the change from PR #1497 which was reverted in PR #1548. The original broke the workflow YAML because the PowerShell here-string content and closing tag had zero indentation, which terminated the YAML literal block scalar (run: |). Fixed by indenting the here-string body to match the block indentation level; YAML strips the leading spaces, leaving valid PowerShell with the closing tag at column 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SteveSandersonMS
added a commit
that referenced
this pull request
Feb 20, 2026
Re-applies the change from PR #1497 which was reverted in PR #1548. The original broke the workflow YAML because the PowerShell here-string content and closing tag had zero indentation, which terminated the YAML literal block scalar (run: |). Fixed by indenting the here-string body to match the block indentation level; YAML strips the leading spaces, leaving valid PowerShell with the closing tag at column 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1497
https://github.com/github/copilot-cli/actions/runs/22186218770