Merge pull request #22730 from geoffw0/qualitytests3

C++: Fill gaps in query tests (part 3)

Author: geoffw0

cpp/ql/test/query-tests/Best Practices/Exceptions/AccidentalRethrow/AccidentalRethrow.expected

@@ -0,0 +1,2 @@
+| test.cpp:2:3:2:7 | re-throw exception  | As there is no current exception, this rethrow expression will terminate the program. |
+| test.cpp:6:3:6:7 | re-throw exception  | As there is no current exception, this rethrow expression will terminate the program. |

cpp/ql/test/query-tests/Best Practices/Exceptions/AccidentalRethrow/AccidentalRethrow.qlref

@@ -0,0 +1,2 @@
+query: Best Practices/Exceptions/AccidentalRethrow.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

cpp/ql/test/query-tests/Best Practices/Exceptions/AccidentalRethrow/test.cpp

@@ -0,0 +1,34 @@
+void rethrowOutsideCatch() {
+  throw; // $ Alert
+}
+
+void helperRethrow() {
+  throw; // $ Alert
+}
+
+void safeRethrowInCatch() {
+  try {
+  } catch (...) {
+    throw;
+  }
+}
+
+// The function name matches "%exception%", so a rethrow here is assumed to
+// be intentional even though it is lexically and dynamically outside any
+// catch block.
+void rethrowException() {
+  throw;
+}
+
+// Not lexically inside a catch block, but every call to this function is
+// made from within a catch block, so the rethrow is assumed to be safe.
+void calledFromCatch() {
+  throw;
+}
+
+void triggersFromCatch() {
+  try {
+  } catch (...) {
+    calledFromCatch();
+  }
+}

cpp/ql/test/query-tests/Best Practices/Exceptions/CatchingByValue/CatchingByValue.expected

@@ -0,0 +1,2 @@
+| test.cpp:12:32:12:34 | { ... } | This should catch a DerivedException by (const) reference rather than by value. |
+| test.cpp:16:29:16:31 | { ... } | This should catch a BaseException by (const) reference rather than by value. |

cpp/ql/test/query-tests/Best Practices/Exceptions/CatchingByValue/CatchingByValue.qlref

@@ -0,0 +1,2 @@
+query: Best Practices/Exceptions/CatchingByValue.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

cpp/ql/test/query-tests/Best Practices/Exceptions/CatchingByValue/test.cpp

@@ -0,0 +1,33 @@
+class BaseException {
+public:
+  virtual ~BaseException() {}
+};
+
+class DerivedException : public BaseException {
+};
+
+void catchByValueDerived() {
+  try {
+    throw DerivedException();
+  } catch (DerivedException e) { } // $ Alert
+
+  try {
+    throw BaseException();
+  } catch (BaseException e) { } // $ Alert
+
+  try {
+    throw DerivedException();
+  } catch (DerivedException &e) { }
+
+  try {
+    throw DerivedException();
+  } catch (BaseException &e) { }
+
+  try {
+    throw new BaseException();
+  } catch (BaseException *e) { }
+
+  try {
+    throw DerivedException();
+  } catch (...) { }
+}

cpp/ql/test/query-tests/Best Practices/Exceptions/LeakyCatch/LeakyCatch.expected

@@ -0,0 +1,2 @@
+| test.cpp:21:28:21:30 | { ... } | This catch block does not free the caught exception, thereby leaking memory. |
+| test.cpp:27:31:27:51 | { ... } | This catch block does not free the caught exception, thereby leaking memory. |

cpp/ql/test/query-tests/Best Practices/Exceptions/LeakyCatch/LeakyCatch.qlref

@@ -0,0 +1,2 @@
+query: Best Practices/Exceptions/LeakyCatch.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

cpp/ql/test/query-tests/Best Practices/Exceptions/LeakyCatch/test.cpp

@@ -0,0 +1,60 @@
+// --- definitions ---
+
+class MyException {
+public:
+  void ReportError() {}
+  void Delete() {}
+};
+
+class OtherException {
+public:
+  void ReportError() {}
+};
+
+void handle(OtherException *e) {}
+
+// --- test cases ---
+
+void leakyCatchEmpty() {
+  try {
+    // ...
+  } catch (MyException *e) { } // $ Alert
+}
+
+void leakyCatchNoDelete() {
+  try {
+    // ...
+  } catch (OtherException *e) { e->ReportError(); } // $ Alert
+}
+
+void catchWithDeleteMethodCall() {
+  try {
+    // ...
+  } catch (MyException *e) {
+    e->ReportError();
+    e->Delete();
+  }
+}
+
+void catchWithOperatorDelete() {
+  try {
+    // ...
+  } catch (MyException *e) {
+    e->ReportError();
+    delete e;
+  }
+}
+
+void catchWithPassToFunction() {
+  try {
+    // ...
+  } catch (OtherException *e) {
+    handle(e);
+  }
+}
+
+void catchByValueNotPointer() {
+  try {
+    // ...
+  } catch (MyException e) { }
+}

cpp/ql/test/query-tests/Best Practices/Exceptions/ThrowingPointers/ThrowingPointers.expected

@@ -0,0 +1 @@
+| test.cpp:5:3:5:25 | throw ... | This should throw a MyException rather than a pointer to one. |