From 87b30f7a7ecfac26eb3edd81db68e23ae63b8f12 Mon Sep 17 00:00:00 2001 From: Francesco Gringl-Novy Date: Mon, 15 Jun 2026 10:11:49 +0200 Subject: [PATCH] ref(tanstackstart-react): Use `@sentry/conventions` Source span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) --- packages/tanstackstart-react/package.json | 2 +- .../tanstackstart-react/src/server/routeParametrization.ts | 6 +++--- yarn.lock | 5 +++++ 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/tanstackstart-react/package.json b/packages/tanstackstart-react/package.json index 5df5adccd1e3..8531cb9cc9d9 100644 --- a/packages/tanstackstart-react/package.json +++ b/packages/tanstackstart-react/package.json @@ -64,8 +64,8 @@ }, "dependencies": { "@opentelemetry/api": "^1.9.1", - "@opentelemetry/semantic-conventions": "^1.40.0", "@sentry/browser-utils": "10.58.0", + "@sentry/conventions": "^0.11.0", "@sentry/core": "10.58.0", "@sentry/node": "10.58.0", "@sentry/react": "10.58.0", diff --git a/packages/tanstackstart-react/src/server/routeParametrization.ts b/packages/tanstackstart-react/src/server/routeParametrization.ts index bd1d1d904770..395451a1bc15 100644 --- a/packages/tanstackstart-react/src/server/routeParametrization.ts +++ b/packages/tanstackstart-react/src/server/routeParametrization.ts @@ -1,4 +1,4 @@ -import { ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions'; +import { HTTP_ROUTE } from '@sentry/conventions/attributes'; import { escapeStringForRegex, getActiveSpan, @@ -54,13 +54,13 @@ export function updateSpanWithRouteParametrization(method: string, pathname: str const rootSpan = getRootSpan(activeSpan); const rootSpanData = spanToJSON(rootSpan).data; - if (rootSpanData?.[ATTR_HTTP_ROUTE]) { + if (rootSpanData?.[HTTP_ROUTE]) { return; } const transactionName = `${method} ${matchedPattern}`; updateSpanName(rootSpan, transactionName); - rootSpan.setAttribute(ATTR_HTTP_ROUTE, matchedPattern); + rootSpan.setAttribute(HTTP_ROUTE, matchedPattern); rootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route'); getCurrentScope().setTransactionName(transactionName); } diff --git a/yarn.lock b/yarn.lock index 61fbf639cfc9..72f2a5e06140 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7578,6 +7578,11 @@ "@sentry/cli-win32-i686" "2.58.6" "@sentry/cli-win32-x64" "2.58.6" +"@sentry/conventions@^0.11.0": + version "0.11.0" + resolved "https://registry.yarnpkg.com/@sentry/conventions/-/conventions-0.11.0.tgz#5a324b8368dc5c141260bd8ccc684756ea3dd843" + integrity sha512-AQTAKeq9mDpOElDFSPymZTPZF/c50rk355mWTf5Y1ZxZJKKOBli5qTttskJyCxrE5ynNgN1KwcXoU5MRrMSRmQ== + "@sentry/node-cpu-profiler@^2.4.2": version "2.4.2" resolved "https://registry.yarnpkg.com/@sentry/node-cpu-profiler/-/node-cpu-profiler-2.4.2.tgz#d0ba01370545297d015df1497daf7f81e27f2ab5"