docs: use safe casts in Android Gradle signing configuration - #13743
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refines the Android deployment documentation by improving phrasing, punctuation, and formatting, as well as updating a Kotlin Gradle configuration snippet to use safe casts (as? String) instead of unsafe casts. The reviewer suggests a further improvement to use the standard getProperty(key) method on the Properties object, which is more idiomatic and avoids the need for casting.
|
Staged preview of the updated docs.flutter.dev site (updated for commit 4ef723a): https://flutter-docs-prod--docs-pr13743-ticket-542694649-issue-3x37sphp.web.app |
|
Staged preview of the updated flutter.dev site (updated for commit 4ef723a): https://flutter-dev-230821--www-pr13743-ticket-542694649-issue-f13zl06g.web.app |
|
Please use a more descriptive title for the PR. thx |
lamek
changed the title
…h apkanalyzer phrasing
8bf402d to
ce4b2f4
Compare
|
@sfshaza2 updated with your feedback. Thanks for the review. |
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
I'll go ahead and approve, but please first fix the nits I've marked.
|
Updated, thank you. |
Updates the Android `build.gradle.kts` release signing example to use safe casts (`as? String`) instead of unsafe casts (`as String`). This prevents Gradle configuration from crashing on debug builds when `key.properties` is absent. Fixes #11995 ## Presubmit checklist - [ ] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [ ] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
4 participants
Updates the Android
build.gradle.ktsrelease signing example to use safe casts (as? String) instead of unsafe casts (as String). This prevents Gradle configuration from crashing on debug builds whenkey.propertiesis absent.Fixes #11995
Presubmit checklist
of 80 characters or fewer.