Repository navigation
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
| { | ||
| ClrVirtualProtect((BYTE*)methodRegion.coldStartAddress, methodRegion.coldSize, PAGE_EXECUTE_READWRITE, &oldProtect); | ||
| if (!ClrVirtualProtect((BYTE*)methodRegion.coldStartAddress, methodRegion.coldSize, PAGE_EXECUTE_READWRITE, &oldProtect)) | ||
| ThrowLastError(); |
There was a problem hiding this comment.
Should we fail fast instead of throwing an exception that would leak into the managed code and be possibly swallowed or change the flow?
There was a problem hiding this comment.
I think this should ether be ignored or be a failfast.
There was a problem hiding this comment.
@copilot make failure to change protection for the purpose of GC stress a failfast.
There was a problem hiding this comment.
Addressed in 8909fd0. All three GC-stress protection-failure paths now use the fatal-error policy instead of throwing. The R2R regression passes; forcing a protection failure in LLDB produced the fatal diagnostic and SIGABRT.
|
/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Co-authored-by: VSadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: VSadov <8218165+VSadov@users.noreply.github.com>
8909fd0 to
c9bf9db
Compare
|
/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Instruction-level GC stress currently instruments JIT-compiled code but skips ReadyToRun methods.
SetupGcCoveragebefore publishing R2R entry points, including async resumption stubs. Serialize setup and use canonical method identity/default code versions for shared generic code.