Skip to content

Commit d17c292

Browse files
authored
fix: import workspace crashes on retry after failed backend import (baserow#5141)
* Fix import workspace crashes on retry after failed backend import * Review changes
1 parent b3a550d commit d17c292

3 files changed

Lines changed: 10 additions & 25 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "bug",
3+
"message": "Fix import workspace crashes on retry after failed backend import",
4+
"issue_origin": "github",
5+
"issue_number": 5140,
6+
"domain": "core",
7+
"bullet_points": [],
8+
"created_at": "2026-04-07"
9+
}

web-frontend/modules/core/components/import/ImportWorkspaceForm.vue

Lines changed: 0 additions & 17 deletions
This file was deleted.

web-frontend/modules/core/components/import/ImportWorkspaceModal.vue

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@
9292
/>
9393
</div>
9494

95-
<ImportWorkspaceForm ref="form" @submitted="importWorkspace" />
96-
9795
<div
9896
class="import-workspace__button-section"
9997
:class="{
@@ -115,7 +113,7 @@
115113
size="large"
116114
:loading="importing"
117115
:disabled="importing"
118-
@click="submitForm"
116+
@click="importWorkspace"
119117
>
120118
{{ $t('importWorkspaceModal.import') }}
121119
</Button>
@@ -134,7 +132,6 @@ import { mimetype2icon } from '@baserow/modules/core/utils/fileTypeToIcon'
134132
import job from '@baserow/modules/core/mixins/job'
135133
import modal from '@baserow/modules/core/mixins/modal'
136134
import error from '@baserow/modules/core/mixins/error'
137-
import ImportWorkspaceForm from '@baserow/modules/core/components/import/ImportWorkspaceForm.vue'
138135
import { notifyIf } from '@baserow/modules/core/utils/error'
139136
import { ImportApplicationsJobType } from '@baserow/modules/core/jobTypes'
140137
import { ResponseErrorMessage } from '@baserow/modules/core/plugins/clientHandler'
@@ -161,7 +158,6 @@ export default {
161158
components: {
162159
UploadFileDropzone,
163160
SelectedFileDetails,
164-
ImportWorkspaceForm,
165161
ImportApplicationSelector,
166162
},
167163
mixins: [modal, error, job],
@@ -217,9 +213,6 @@ export default {
217213
},
218214
},
219215
methods: {
220-
submitForm() {
221-
this.$refs.form.submit()
222-
},
223216
show(...args) {
224217
this.hideError()
225218
this.checkPendingImport()

0 commit comments

Comments
 (0)