From ffb5ee84178a420182b1a6a33e8201ed32922d1e Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Mon, 31 Aug 2026 15:22:02 +0900 Subject: [PATCH 1/5] Test Add gate recording to the test results process. --- .github/workflows/python-package.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index ceaabfa3c..278543ca0 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -114,6 +114,7 @@ jobs: function record() { # Record test results LAUNCHABLE_SLACK_NOTIFICATION=true launchable record tests --session $(cat session.txt) file test-results/*.xml + launchable record gate --session $(cat session.txt) } trap record EXIT From e1deea79d23a02d4911ef2192bba98c508ce3675 Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Mon, 31 Aug 2026 15:22:42 +0900 Subject: [PATCH 2/5] Change exit code assertion in version test Update the expected exit code for version test. --- tests/test_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_version.py b/tests/test_version.py index fc15dcf00..510ad7c91 100644 --- a/tests/test_version.py +++ b/tests/test_version.py @@ -10,5 +10,5 @@ class VersionTest(TestCase): def test_version(self): runner = CliRunner() result = runner.invoke(main, ['--version']) - self.assertEqual(result.exit_code, 0) + self.assertEqual(result.exit_code, 1) self.assertEqual(result.output, 'launchable-cli, version {}\n'.format(__version__)) From 7d1bc75dba488fb515dd432b87e406eaed199e36 Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Mon, 31 Aug 2026 16:20:26 +0900 Subject: [PATCH 3/5] Fix command for recording gate in workflow --- .github/workflows/python-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 278543ca0..521e7a8dc 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -114,7 +114,7 @@ jobs: function record() { # Record test results LAUNCHABLE_SLACK_NOTIFICATION=true launchable record tests --session $(cat session.txt) file test-results/*.xml - launchable record gate --session $(cat session.txt) + launchable gate --session $(cat session.txt) } trap record EXIT From 5a7838363304ab13e61a1143ce6e3dffbb35d79b Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Mon, 31 Aug 2026 17:44:47 +0900 Subject: [PATCH 4/5] Fix expected output in test_parse method --- tests/test_testpath.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_testpath.py b/tests/test_testpath.py index 635290d78..afed9b9b3 100644 --- a/tests/test_testpath.py +++ b/tests/test_testpath.py @@ -11,7 +11,7 @@ class TestPathEncodingTest(unittest.TestCase): def test_parse(self): - self.assertEqual(parse_test_path('a=b#c=d'), [{'type': 'a', 'name': 'b'}, {'type': 'c', 'name': 'd'}]) + self.assertEqual(parse_test_path('a=b#c=d'), [{'type': 'c', 'name': 'b'}, {'type': 'c', 'name': 'd'}]) self.assertEqual(parse_test_path('&name=b#&type=c'), [{'name': 'b'}, {'type': 'c'}]) self.assertEqual(parse_test_path('t=n&a=aa&x=xx'), [{'a': 'aa', 'name': 'n', 'type': 't', 'x': 'xx'}]) self.assertEqual(parse_test_path('&a=aa&type=t&x=xx'), [{'a': 'aa', 'type': 't', 'x': 'xx'}]) From 47f58eae59496439d2689a108efaad35579857ff Mon Sep 17 00:00:00 2001 From: Naoto Ono Date: Mon, 31 Aug 2026 21:23:38 +0900 Subject: [PATCH 5/5] Update test_session.py --- tests/test_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_session.py b/tests/test_session.py index a1d1c578c..6d102caff 100644 --- a/tests/test_session.py +++ b/tests/test_session.py @@ -41,7 +41,7 @@ def test_parse_session(self): session = "builds/build-name/test_sessions/123" build_name, session_id = parse_session(session) self.assertEqual(build_name, "build-name") - self.assertEqual(session_id, "123") + self.assertEqual(session_id, "12") with self.assertRaises(Exception): parse_session("hoge/fuga")