Repository navigation
Conversation
…ll request verify-attach.yml runs when a verify-remote session ends, reads the evidence the session handed off, and writes it into the pull request description with the token of the verify-evidence environment. scripts/verify-attach.mjs is a byte copy of .github/scripts/verify-attach.mjs on main of clerk/clerk-ios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b86f1cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⛔ Files ignored due to path filters: 1
⚙️ Run configuration
⛔ Files ignored due to path filters: 1
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
…-publish Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…nto mike/expo-verify-r4-publish
…nto mike/expo-verify-r4-publish
…-publish Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-publish Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-publish Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Description
This is the last of four pull requests that replace the eleven of stack #10100. It holds #10163 and the edits that #10219, #10221, and #10230 made to the publish script. It sits on #10237, and it adds nothing to the device tests or the fixture.
A cloud agent cannot put a run's video and screenshots on its pull request. Its sandbox refuses the upload, and the Actions token cannot attach files. So
attachin #10237 hands the files to the session's runner, which keeps them as the artifactverify-evidence. This pull request adds the workflow that reads that artifact and puts the evidence in the pull request description, as a table of a before run and an after run..github/workflows/verify-attach.ymlscripts/verify-attach.mjs.github/scripts/verify-attach.mjsonmainof clerk/clerk-ios, reviewed there in clerk/clerk-ios#688 and the pull requests after it.scripts/verify-attach.test.mjsdescribeanditfromvitest..github/workflows/ci.ymlUnit Testsjob, on its Node 24 leg..github/actionlint.yamlconcurrency.queuethrough in this one workflow, because actionlint 1.7 does not know the key..github/workflows/actions.lockWhat needs attention is the trust boundary of
verify-attach.yml:workflow_runwhen averify-remote.ymlsession that someone started byworkflow_dispatchin this repository ends. GitHub starts it only from the copy onmain, so it does nothing until this stack has merged.actions: readandcontents: read. The token that edits the description isVERIFY_EVIDENCE_TOKEN, a secret of the environmentverify-evidence, which allows onlymain. Only the step that runsghholds it. The environment and the secret exist. There is no repository secret of that name, and there must not be one.Two things are not proven, and cannot be until this is on
main. One is that a real session's end starts the workflow and the job gets the environment's secret. The other is that a fine-grained token with only "Pull requests: read and write" can attach files withgh pr edit --attach.vitest run --root scripts verify-attachpasses 198 of 198 tests on this branch, andnpm testinintegration/expo-native/passes 917 of 917. The device suite passed on this stack's top commit (e828e76619) in run 39276831929: iOS 17 of 17, Android 16 of 16. One Android test passed on its second try, after the first launch of a cold emulator took longer than 60 seconds to show the home.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code