From 69b46ea84e812bdcfc5cf1966ca0ec1eb6401cdf Mon Sep 17 00:00:00 2001
From: reginaldalfret <reginaldalfret@gmail.com>
Date: Tue, 6 Oct 2026 11:46:42 +0530
Subject: [PATCH] packages: show build log link for all packages with build ID

Currently, the build log link was only displayed if the package was marked as non-reproducible (RebuilderdStatus.BAD). However, the build log is valuable for reproducible packages as well, e.g. to inspect build options and environment used during build time.

Display the build log link whenever rbstatus and rbstatus.build_id are present, and conditionally append the diffoscope link only when the package is not reproducible. Also remove an extraneous stray <tr> tag inside the <ul> action list.

Fixes #611

Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
---
 packages/tests/test_views.py            | 32 +++++++++++++++++++++++++
 templates/packages/package_details.html |  6 ++---
 2 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/packages/tests/test_views.py b/packages/tests/test_views.py
index b8bdfa2b4..f43e3ef21 100644
--- a/packages/tests/test_views.py
+++ b/packages/tests/test_views.py
@@ -137,3 +137,35 @@ def test_groups_details(client, package):
 def test_stale_relations(developer_client):
     response = developer_client.get('/packages/stale_relations/')
     assert response.status_code == 200
+
+
+def test_packages_detail_rebuilderd_buildlog_link(developer_client, package):
+    from main.models import RebuilderdStatus
+    from packages.models import Package
+
+    pkg = Package.objects.get(pkgname='linux')
+    rb = RebuilderdStatus.objects.create(
+        pkg=pkg,
+        pkgname=pkg.pkgname,
+        pkgver=pkg.pkgver,
+        pkgrel=pkg.pkgrel,
+        epoch=pkg.epoch,
+        arch=pkg.arch,
+        repo=pkg.repo,
+        status=RebuilderdStatus.GOOD,
+        build_id=12345,
+    )
+
+    response = developer_client.get('/packages/core/x86_64/linux/')
+    assert response.status_code == 200
+    content = response.content.decode('utf-8')
+    assert 'https://reproducible.archlinux.org/api/v0/builds/12345/log' in content
+    assert 'Diffoscope' not in content
+
+    rb.status = RebuilderdStatus.BAD
+    rb.save()
+    response = developer_client.get('/packages/core/x86_64/linux/')
+    assert response.status_code == 200
+    content = response.content.decode('utf-8')
+    assert 'https://reproducible.archlinux.org/api/v0/builds/12345/log' in content
+    assert 'https://reproducible.archlinux.org/api/v0/builds/12345/diffoscope' in content
diff --git a/templates/packages/package_details.html b/templates/packages/package_details.html
index f0fb5164f..4788a18a3 100644
--- a/templates/packages/package_details.html
+++ b/templates/packages/package_details.html
@@ -20,10 +20,10 @@ <h4>Package Actions</h4>
                     <a href="{% man_link pkg %}" title="List manpages in {{ pkg.pkgname }}">Manual Pages</a>
                 </li>
                 <li><a href="{% sec_link pkg %}" title="View security issues for {{ pkg.pkgname }}">Security Issues</a></li>
-        	{% if user.is_authenticated and notreproducible %}<tr>
+        	{% if user.is_authenticated and rbstatus and rbstatus.build_id %}
                 <li>
-		    <a href="{% rebuilderd_buildlog_link rbstatus %}" title="View build log for {{ pkg.pkgname }}">Build log</a> /
-		    <a href="{% rebuilderd_diffoscope_link rbstatus %}" title="View diffoscope result for {{ pkg.pkgname }}">Diffoscope</a>
+		    <a href="{% rebuilderd_buildlog_link rbstatus %}" title="View build log for {{ pkg.pkgname }}">Build log</a>{% if notreproducible %} /
+		    <a href="{% rebuilderd_diffoscope_link rbstatus %}" title="View diffoscope result for {{ pkg.pkgname }}">Diffoscope</a>{% endif %}
 		</li>
 		{% endif %}
                 {% if pkg.flag_date %}