From e1fa22db54008411abfd3661a9708383f29587c3 Mon Sep 17 00:00:00 2001 From: Rui Mo Date: Tue, 1 Sep 2026 15:22:47 +0100 Subject: [PATCH] Re-enable decimal tests --- .../gluten/execution/VeloxOrcDataTypeValidationSuite.scala | 6 +----- .../execution/VeloxParquetDataTypeValidationSuite.scala | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala index de942f4ba28..87c641a2dcd 100644 --- a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala +++ b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala @@ -429,11 +429,7 @@ class VeloxOrcDataTypeValidationSuite extends VeloxWholeStageTransformerSuite { " type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => } } - // TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith. - // The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan - // (velox#18159), and merging it with the existing IsNotNull filter throws - // "mergeWith() is not supported". - ignore("Decimal type") { + test("Decimal type") { // Validation: BatchScan Project Aggregate Expand Sort Limit runQueryAndCompare( "select int, decimal from type1 " + diff --git a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala index 01b23b1129a..1408b4c6519 100644 --- a/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala +++ b/backends-velox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala @@ -430,11 +430,7 @@ class VeloxParquetDataTypeValidationSuite extends VeloxWholeStageTransformerSuit " type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => } } - // TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith. - // The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan - // (velox#18159), and merging it with the existing IsNotNull filter throws - // "mergeWith() is not supported". - ignore("Decimal type") { + test("Decimal type") { // Validation: BatchScan Project Aggregate Expand Sort Limit runQueryAndCompare( "select int, decimal from type1 " +