From 34564e9f68d77e5137a98900a701946280c15ae0 Mon Sep 17 00:00:00 2001 From: lidongyang Date: Tue, 15 Sep 2026 20:26:24 +0800 Subject: [PATCH 1/3] [chore](build) Reduce redundant Actions on branch-4.1 Limit release-branch Code Checks push runs to shell-script changes, remove the duplicate large-file push run and obsolete two-approval workflow, and path-filter the thirdparty PR workflow. Preserve existing PR, comment, and manual triggers. --- .github/workflows/build-thirdparty.yml | 5 +++ .github/workflows/code-checks.yml | 9 +++++- .github/workflows/lfs-warning.yml | 3 +- .github/workflows/pr-approve-status.yml | 43 ------------------------- 4 files changed, 14 insertions(+), 46 deletions(-) delete mode 100644 .github/workflows/pr-approve-status.yml diff --git a/.github/workflows/build-thirdparty.yml b/.github/workflows/build-thirdparty.yml index 90b8f33640c8ea..f8de0f8008da31 100644 --- a/.github/workflows/build-thirdparty.yml +++ b/.github/workflows/build-thirdparty.yml @@ -19,6 +19,11 @@ name: Build Third Party Libraries on: pull_request: + paths: + - 'thirdparty/**' + - 'env.sh' + - 'regression-test/pipeline/external/conf/fe.conf' + - '.github/workflows/build-thirdparty.yml' workflow_dispatch: issue_comment: types: [ created ] diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index ac368fcf6a2197..8c903c220e92a1 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -17,7 +17,14 @@ name: Code Checks -on: [push, pull_request_target] +on: + push: + paths: + - '**/*.sh' + - '**/*.bash' + - '**/*.zsh' + - 'tools/single-node-cluster/multi-fe' + pull_request_target: jobs: shellcheck: diff --git a/.github/workflows/lfs-warning.yml b/.github/workflows/lfs-warning.yml index 4db79ceded9eea..2bc7d1a591a8f7 100644 --- a/.github/workflows/lfs-warning.yml +++ b/.github/workflows/lfs-warning.yml @@ -18,7 +18,7 @@ --- name: 'Check Large File' -on: [push, pull_request_target] +on: pull_request_target jobs: large-file-checker: @@ -44,4 +44,3 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} filesizelimit: 1MB - diff --git a/.github/workflows/pr-approve-status.yml b/.github/workflows/pr-approve-status.yml deleted file mode 100644 index fe0a0161607cff..00000000000000 --- a/.github/workflows/pr-approve-status.yml +++ /dev/null @@ -1,43 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. ---- -name: Need_2_Approval - -on: - pull_request_review: - types: [ submitted ] - -jobs: - Need_2_Approval: - runs-on: ubuntu-latest - timeout-minutes: 5 - steps: - - uses: actions/checkout@v3 - - name: Install Python dependencies - uses: actions/setup-python@v5 - with: - python-version: '3.10' # Adjust if needed - - name: Install match library - run: | - pip install --upgrade pip - pip install match - pip install requests - - name: Run Python script - run: | - python tools/maintainers/check_review.py ${{ github.event.pull_request.number }} ${{secrets.GITHUB_TOKEN}} -env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 12da45dd30ea6777f201fa12b96e7851dde85f46 Mon Sep 17 00:00:00 2001 From: lidongyang Date: Tue, 15 Sep 2026 20:55:31 +0800 Subject: [PATCH 2/3] [chore](build) Exclude external regression FE config from thirdparty triggers Remove the regression-only FE config from both the PR entry path filter and the existing focused test change filter. Thirdparty-related changes still run the script test, including its ADBC configuration assertion. --- .github/workflows/build-thirdparty.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build-thirdparty.yml b/.github/workflows/build-thirdparty.yml index f8de0f8008da31..42f7abe95ace48 100644 --- a/.github/workflows/build-thirdparty.yml +++ b/.github/workflows/build-thirdparty.yml @@ -22,7 +22,6 @@ on: paths: - 'thirdparty/**' - 'env.sh' - - 'regression-test/pipeline/external/conf/fe.conf' - '.github/workflows/build-thirdparty.yml' workflow_dispatch: issue_comment: @@ -61,7 +60,6 @@ jobs: - 'thirdparty/**' - 'env.sh' focused_test_changes: - - 'regression-test/pipeline/external/conf/fe.conf' - 'thirdparty/test/adbc-jni-config-test.sh' - '.github/workflows/build-thirdparty.yml' From 03de7faffc735ae90154265d82ff3f37383f2e0a Mon Sep 17 00:00:00 2001 From: lidongyang Date: Tue, 15 Sep 2026 21:15:41 +0800 Subject: [PATCH 3/3] [chore](build) Defer Code Checks trigger optimization Restore the original Code Checks triggers. The shell filename filter could miss extensionless shell scripts, so this PR retains only the confirmed release-branch Action reductions. --- .github/workflows/code-checks.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 8c903c220e92a1..ac368fcf6a2197 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -17,14 +17,7 @@ name: Code Checks -on: - push: - paths: - - '**/*.sh' - - '**/*.bash' - - '**/*.zsh' - - 'tools/single-node-cluster/multi-fe' - pull_request_target: +on: [push, pull_request_target] jobs: shellcheck: