Skip to content

fix: track the time takes to init loser tree and build last in progress batches#23698

Open
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:count-initial-loser-tree-time
Open

fix: track the time takes to init loser tree and build last in progress batches#23698
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:count-initial-loser-tree-time

Conversation

@rluvaton

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A

Rationale for this change

My latest rewrite to SortPreservingMergeStream forgot to remove comment and to count the initial loser tree init + last in progress emit time

What changes are included in this PR?

  • Remove outdated comment
  • Count loser tree init time
  • Count building last in progress record batches time

Are these changes tested?

No, since it is tricky to test that and any attempt can be flaky by design

Are there any user-facing changes?

No

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jul 19, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.67%. Comparing base (67947b6) to head (db9ed41).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23698      +/-   ##
==========================================
- Coverage   80.67%   80.67%   -0.01%     
==========================================
  Files        1088     1088              
  Lines      367591   367592       +1     
  Branches   367591   367592       +1     
==========================================
- Hits       296563   296546      -17     
- Misses      53374    53385      +11     
- Partials    17654    17661       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants