From 7f25c67ea7da396dbe8bda40000a87b63b94c41d Mon Sep 17 00:00:00 2001 From: LucaCappelletti94 Date: Wed, 11 Nov 2026 22:33:12 +0100 Subject: [PATCH] PostgreSQL: Support `VIEW` members in `ALTER EXTENSION` --- fuzz/fuzz_seeds/postgres_alter_extension.sql | 1 + src/ast/ddl.rs | 3 +++ src/parser/mod.rs | 2 ++ tests/sqlparser_postgres.rs | 15 +++++++++------ 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/fuzz/fuzz_seeds/postgres_alter_extension.sql b/fuzz/fuzz_seeds/postgres_alter_extension.sql index d966f56be8..d747a4c329 100644 --- a/fuzz/fuzz_seeds/postgres_alter_extension.sql +++ b/fuzz/fuzz_seeds/postgres_alter_extension.sql @@ -2,3 +2,4 @@ ALTER EXTENSION citext SET SCHEMA other; ALTER EXTENSION citext UPDATE; ALTER EXTENSION "uuid-ossp" UPDATE TO '1.1'; ALTER EXTENSION citext ADD TABLE public.t; +ALTER EXTENSION citext DROP VIEW public.v; diff --git a/src/ast/ddl.rs b/src/ast/ddl.rs index 3fa9a6ca58..5ae188583f 100644 --- a/src/ast/ddl.rs +++ b/src/ast/ddl.rs @@ -4928,6 +4928,8 @@ pub enum AlterExtensionOperation { pub enum AlterExtensionMember { /// `TABLE object_name` Table(ObjectName), + /// `VIEW object_name` + View(ObjectName), } impl fmt::Display for AlterExtensionOperation { @@ -4953,6 +4955,7 @@ impl fmt::Display for AlterExtensionMember { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match self { AlterExtensionMember::Table(name) => write!(f, "TABLE {name}"), + AlterExtensionMember::View(name) => write!(f, "VIEW {name}"), } } } diff --git a/src/parser/mod.rs b/src/parser/mod.rs index b138703866..ddab1d9e71 100644 --- a/src/parser/mod.rs +++ b/src/parser/mod.rs @@ -12541,6 +12541,8 @@ impl<'a> Parser<'a> { fn parse_alter_extension_member(&mut self) -> Result { if self.parse_keyword(Keyword::TABLE) { Ok(AlterExtensionMember::Table(self.parse_object_name(false)?)) + } else if self.parse_keyword(Keyword::VIEW) { + Ok(AlterExtensionMember::View(self.parse_object_name(false)?)) } else { self.expected_ref( "member object type after ADD or DROP", diff --git a/tests/sqlparser_postgres.rs b/tests/sqlparser_postgres.rs index 730f3c5e83..73972bcccc 100644 --- a/tests/sqlparser_postgres.rs +++ b/tests/sqlparser_postgres.rs @@ -13530,6 +13530,7 @@ fn alter_extension_member_round_trip_forms(action: &str) { let sqls = [ format!("ALTER EXTENSION ext_name {action} TABLE t"), format!("ALTER EXTENSION ext_name {action} TABLE schema.t"), + format!("ALTER EXTENSION ext_name {action} VIEW v"), ]; for sql in sqls { pg_and_generic().verified_stmt(&sql); @@ -13674,12 +13675,14 @@ fn parse_alter_extension_add_member() { ); } - assert_eq!( - pg_and_generic() - .parse_sql_statements("ALTER EXTENSION ext_name ADD TABLE") - .unwrap_err(), - ParserError::ParserError("Expected: identifier, found: EOF".to_string()) - ); + for member in ["TABLE", "VIEW"] { + let sql = format!("ALTER EXTENSION ext_name ADD {member}"); + assert_eq!( + pg_and_generic().parse_sql_statements(&sql).unwrap_err(), + ParserError::ParserError("Expected: identifier, found: EOF".to_string()), + "{sql}" + ); + } } #[test]