build: update to TypeScript 6

Updates the repo to TypeScript 6 and resolves the resulting test failures.

Author: crisbeto

MODULE.bazel

@@ -165,9 +165,9 @@ use_repo(npm, "npm")
 rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext")
 rules_ts_ext.deps(
     name = "angular_cli_npm_typescript",
-    # Obtained by: npm info typescript@5.9.3 dist.integrity
-    ts_integrity = "sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==",
-    ts_version = "5.9.3",
+    # Obtained by: npm info typescript@6.0.0-beta dist.integrity
+    ts_integrity = "sha512-CldZdztDpQRLM1HC6WDQjQkQN5Ub5zRau737a1diGh3lPmb9oRsaWHk1y5iqK0o7+1bNJ0oXfEGRkAogFZBL+Q==",
+    ts_version = "6.0.0-beta",
 )
 use_repo(rules_ts_ext, **{"npm_typescript": "angular_cli_npm_typescript"})
 

MODULE.bazel.lock

@@ -2,7 +2,6 @@
   "extends": "./tsconfig.app.json",
   "compilerOptions": {
     "outDir": "../dist-server",
-    "baseUrl": "./",
     "types": ["@angular/localize", "node"]
   },
   "files": [

modules/testing/builder/projects/hello-world-app/src/tsconfig.server.json

@@ -80,7 +80,7 @@ export async function browserBuild(
   scheduleOptions?: ScheduleOptions,
 ): Promise<BrowserBuildOutput> {
   const run = await architect.scheduleTarget(target, overrides, scheduleOptions);
-  const output = (await run.result) as BuilderOutput & { outputs: { path: string }[] };
+  const output = await run.result;
   expect(output.success).toBe(true);
 
   if (!output.success) {

modules/testing/builder/src/test-utils.ts

@@ -127,7 +127,7 @@
     "semver": "7.7.4",
     "source-map-support": "0.5.21",
     "tslib": "2.8.1",
-    "typescript": "5.9.3",
+    "typescript": "6.0.0-beta",
     "undici": "7.22.0",
     "unenv": "^1.10.0",
     "verdaccio": "6.2.9",

package.json

@@ -73,7 +73,7 @@
     "postcss": "^8.4.0",
     "tailwindcss": "^2.0.0 || ^3.0.0 || ^4.0.0",
     "tslib": "^2.3.0",
-    "typescript": ">=5.9 <6.0",
+    "typescript": ">=5.9 <6.1",
     "vitest": "^4.0.8"
   },
   "peerDependenciesMeta": {

packages/angular/build/package.json

@@ -33,7 +33,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         import { Directive, Input } from '@angular/core';
         @Directive({ selector: 'dir', standalone: false })
         export class Dir {
-          @Input() foo: number;
+          @Input() foo!: number;
         }
       `;
 

packages/angular/build/src/builders/application/tests/behavior/rebuild-errors_spec.ts

@@ -55,6 +55,9 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         tsconfig.compilerOptions.isolatedModules = true;
         tsconfig.compilerOptions.jsx = 'react-jsx';
 
+        // There's an implicit `any`, because we don't include the React typings.
+        tsconfig.compilerOptions.noImplicitAny = false;
+
         return JSON.stringify(tsconfig);
       });
 

packages/angular/build/src/builders/application/tests/behavior/typescript-isolated-modules_spec.ts

@@ -83,6 +83,7 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
         tsconfig.compilerOptions.paths = {
           'app-module': ['./a.js'],
         };
+        tsconfig.compilerOptions.allowJs = true;
 
         return JSON.stringify(tsconfig);
       });

packages/angular/build/src/builders/application/tests/behavior/typescript-path-mapping_spec.ts

@@ -20,9 +20,14 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       // Enable tsconfig resolveJsonModule option in tsconfig
       await harness.modifyFile('tsconfig.json', (content) => {
         const tsconfig = JSON.parse(content);
-        tsconfig.compilerOptions.moduleResolution = 'node';
+        tsconfig.compilerOptions.moduleResolution = 'node16';
+        tsconfig.compilerOptions.module = 'node16';
         tsconfig.compilerOptions.resolveJsonModule = true;
 
+        // TODO: TS reports that a deprecation error because `baseUrl` is used,
+        // but we don't have it in our tsconfig. It may be coming from a dependency.
+        tsconfig.compilerOptions.ignoreDeprecations = '6.0';
+
         return JSON.stringify(tsconfig);
       });
 
@@ -44,7 +49,8 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       // Enable tsconfig resolveJsonModule option in tsconfig
       await harness.modifyFile('tsconfig.json', (content) => {
         const tsconfig = JSON.parse(content);
-        tsconfig.compilerOptions.moduleResolution = 'node';
+        tsconfig.compilerOptions.moduleResolution = 'node16';
+        tsconfig.compilerOptions.module = 'node16';
         tsconfig.compilerOptions.resolveJsonModule = undefined;
 
         return JSON.stringify(tsconfig);
@@ -73,7 +79,8 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       // Enable tsconfig resolveJsonModule option in tsconfig
       await harness.modifyFile('tsconfig.json', (content) => {
         const tsconfig = JSON.parse(content);
-        tsconfig.compilerOptions.moduleResolution = 'node';
+        tsconfig.compilerOptions.moduleResolution = 'node16';
+        tsconfig.compilerOptions.module = 'node16';
         tsconfig.compilerOptions.resolveJsonModule = false;
 
         return JSON.stringify(tsconfig);