Validate target status for VuMark instance generation (#2981)

Return TargetStatusNotSuccessError when a VuMark instance generation
request targets a VuMark target that is not yet in the success state.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: adamtheturtle

src/mock_vws/_flask_server/vws.py

@@ -398,9 +398,6 @@ def generate_vumark_instance(target_id: str) -> Response:
         databases=all_databases,
     )
 
-    # ``target_id`` is validated by request validators.
-    del target_id
-
     database = get_database_matching_server_keys(
         request_headers=dict(request.headers),
         request_body=request.data,
@@ -411,6 +408,10 @@ def generate_vumark_instance(target_id: str) -> Response:
     if not isinstance(database, VuMarkDatabase):
         raise InvalidTargetTypeError
 
+    target = database.get_vumark_target(target_id=target_id)
+    if target.status != TargetStatuses.SUCCESS.value:
+        raise TargetStatusNotSuccessError
+
     accept = request.headers.get(key="Accept", default="")
     valid_accept_types: dict[str, bytes] = {
         "image/png": VUMARK_PNG,

src/mock_vws/_requests_mock_server/mock_web_services_api.py

@@ -319,6 +319,11 @@ def generate_vumark_instance(self, request: RequestData) -> _ResponseType:
             if not isinstance(database, VuMarkDatabase):
                 raise InvalidTargetTypeError
 
+            target_id = request.path.split(sep="/")[-2]
+            target = database.get_vumark_target(target_id=target_id)
+            if target.status != TargetStatuses.SUCCESS.value:
+                raise TargetStatusNotSuccessError
+
             accept = dict(request.headers).get("Accept", "")
             if accept not in valid_accept_types:
                 raise InvalidAcceptHeaderError

src/mock_vws/database.py

@@ -203,6 +203,15 @@ class VuMarkDatabase:
         hash=False,
     )
 
+    def get_vumark_target(self, target_id: str) -> VuMarkTarget:
+        """Return a VuMark target from the database with the given ID."""
+        (target,) = (
+            target
+            for target in self.vumark_targets
+            if target.target_id == target_id
+        )
+        return target
+
     def to_dict(self) -> VuMarkDatabaseDict:
         """Dump a VuMark database to a dictionary which can be loaded as
         JSON.

src/mock_vws/target.py

@@ -24,6 +24,9 @@ class VuMarkTargetDict(TypedDict):
 
     target_id: str
     name: str
+    processing_time_seconds: float
+    last_modified_date: str
+    upload_date: str
 
 
 class ImageTargetDict(TypedDict):
@@ -228,14 +231,46 @@ class VuMarkTarget:
     """
 
     name: str
+    processing_time_seconds: float = 0.0
     target_id: str = field(default_factory=_random_hex)
+    last_modified_date: datetime.datetime = field(default_factory=_time_now)
+    upload_date: datetime.datetime = field(default_factory=_time_now)
+
+    @property
+    def status(self) -> str:
+        """Return the status of the target.
+
+        VuMark targets always succeed after processing.
+        """
+        processing_time = datetime.timedelta(
+            seconds=float(self.processing_time_seconds),
+        )
+
+        timezone = self.upload_date.tzinfo
+        now = datetime.datetime.now(tz=timezone)
+        time_since_change = now - self.last_modified_date
+
+        if time_since_change <= processing_time:
+            return TargetStatuses.PROCESSING.value
+
+        return TargetStatuses.SUCCESS.value
 
     @classmethod
     def from_dict(cls, target_dict: VuMarkTargetDict) -> Self:
         """Load a VuMark target from a dictionary."""
+        timezone = ZoneInfo(key="GMT")
+        last_modified_date = datetime.datetime.fromisoformat(
+            target_dict["last_modified_date"],
+        ).replace(tzinfo=timezone)
+        upload_date = datetime.datetime.fromisoformat(
+            target_dict["upload_date"],
+        ).replace(tzinfo=timezone)
         return cls(
             target_id=target_dict["target_id"],
             name=target_dict["name"],
+            processing_time_seconds=target_dict["processing_time_seconds"],
+            last_modified_date=last_modified_date,
+            upload_date=upload_date,
         )
 
     def to_dict(self) -> VuMarkTargetDict:
@@ -245,4 +280,7 @@ def to_dict(self) -> VuMarkTargetDict:
         return {
             "target_id": self.target_id,
             "name": self.name,
+            "processing_time_seconds": float(self.processing_time_seconds),
+            "last_modified_date": self.last_modified_date.isoformat(),
+            "upload_date": self.upload_date.isoformat(),
         }