Skip to content

Commit fed545a

Browse files
leliaclaude
andcommitted
Fail the Docker build when pip check fails
Docker's shell-form RUN only propagates the last command's exit status, so once pip check moved ahead of the SDK_VERSION block its failure was silently discarded whenever SDK_VERSION was empty or the override install succeeded. Gate it explicitly with || exit 1. Addresses PR#289 review finding. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
1 parent 33d6897 commit fed545a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ RUN if [ "$USE_LOCAL_INSTALL" = "true" ]; then \
143143
echo "Failed to install socketsecurity==$CLI_VERSION after 10 attempts"; \
144144
exit 1; \
145145
fi; \
146-
pip check; \
146+
pip check || exit 1; \
147147
if [ ! -z "$SDK_VERSION" ]; then \
148148
pip install --index-url ${PIP_INDEX_URL} --extra-index-url ${PIP_EXTRA_INDEX_URL} socketdev==${SDK_VERSION}; \
149149
fi; \

0 commit comments

Comments
 (0)