Trade API: next steps

[cgewecke]

⚠️ Actively edited. ⚠️

Several things have been raised by the #60 review that should be addressed in subsequent PRs

• Service is can easily fail if one of the (many) external resource calls fails

• Gas price oracles
  • Use fallbacks? e.g gasNow and EthGasStation ?
• CoinGecko token list: especially bad for polygon which makes 4 external calls to compose a list.

  • (from review) In a follow up, we should make this fault tolerant to CoinGecko API failures, return default values for things like estimated USD value, and return some kind of error that indicates CoinGecko failed.

  • Pricing seems pretty time sensitive... perhaps we can have redundancy via another service?
  • Could also maintain our own token list (for metadata) and generate in a CI chron job / publish to github?
  • fallback on the dynamic generation if that fails?

Resolved in #60

• Add a separate flow for an indicative vs firm 0x quotes (Tracking in Add flows for indicative vs. firm quotes in TradeQuoter  #63)

  • https://0x.org/docs/guides/rfqt-in-the-0x-api#indicative-pricing
  • (Indicative) : /swap/v1/price
  • (Firm): /swap/v1/quote (remove intentOnFilling logic?)

• Currency/price formatting

• Currently formats prices as dollar strings.
• Should this be configurable, e.g pick your national currency
• Should formatting be delegated to quote consumer?

[asoong]

Service is can easily fail if one of the (many) external resource calls fails

• Remove the token list fetching
• Have generate function pass in decimals for from_token and to_token; see Postman
• Add new optional param for fetching gas prices; fetch from gas_now
• For coin prices, call CoinGecko. If entire API call fails, assume $0 for all assets. If any prices are missing, assume $0 price.
• Don't need to return any of the coin data like Name, Symbol, etc. Coin response can be removed.