Commit 25d9e58
Skip the attach and prefixed-completion E2E tests on Windows PowerShell
Un-skipping the entire Windows PowerShell E2E suite (now that the host-start
hang is fixed) gave us real WinPS coverage for the first time since #2318, but
it also surfaced two pre-existing WinPS-specific failures that have nothing to
do with host startup:
- `CanAttachScriptWithPathMappings` wedges on the in-box, cross-process
`Debug-Runspace` attach handshake and rides whatever timeout we set. CI
failed it at 10s, then again at exactly 30s after I bumped the budgets, so
it genuinely never completes rather than merely running slow. This is the
in-box attach deadlock tracked by #2323.
- `CanSendCompletionResolveWithModulePrefixRequestAsync` gets an empty
completion list from the Windows PowerShell server for a prefix-imported
command (it fails before any help assertion, so it's help-independent).
That's the same "completion works in PS7 but not WinPS" family as #1355.
Because startup no longer hangs, we don't need #2318's discovery-time
`[SkippableFactOnWindowsPowerShell]` attribute anymore: an in-body
`Skip.If(IsWindowsPowerShell, ...)` runs after `InitializeAsync` (which now
starts the server fine) and skips before the broken code, so both tests skip
cleanly in ~1ms under `powershell.exe` instead of hanging or failing.
This also reverts my earlier timeout bump on `CanAttachScriptWithPathMappings`
(back to the 15s/10s/30s budgets from `main`) since the bigger budgets didn't
help and the test no longer runs on Windows PowerShell anyway. Everything else
stays un-skipped.
Drafted by Copilot (Claude Opus 4.8).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent a4e8a82 commit 25d9e58
2 files changed
Lines changed: 11 additions & 8 deletions
File tree
- test/PowerShellEditorServices.Test.E2E
Lines changed: 7 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
633 | | - | |
634 | | - | |
635 | | - | |
| 633 | + | |
636 | 634 | | |
637 | 635 | | |
638 | 636 | | |
639 | 637 | | |
640 | 638 | | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
641 | 642 | | |
642 | 643 | | |
643 | 644 | | |
| |||
770 | 771 | | |
771 | 772 | | |
772 | 773 | | |
773 | | - | |
| 774 | + | |
774 | 775 | | |
775 | 776 | | |
776 | 777 | | |
| |||
809 | 810 | | |
810 | 811 | | |
811 | 812 | | |
812 | | - | |
813 | | - | |
814 | | - | |
| 813 | + | |
| 814 | + | |
815 | 815 | | |
816 | 816 | | |
817 | 817 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1051 | 1051 | | |
1052 | 1052 | | |
1053 | 1053 | | |
1054 | | - | |
| 1054 | + | |
1055 | 1055 | | |
1056 | 1056 | | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
1057 | 1060 | | |
1058 | 1061 | | |
1059 | 1062 | | |
| |||
0 commit comments