Repository navigation
Vouch request: aeilot #5035
Closed
aeilot
started this conversation in
Vouch Request
Replies: 2 comments
|
/vouch |
0 replies
|
@aeilot has been vouched by @krishicks. You can now submit pull requests to OpenShell. Welcome aboard. Please read CONTRIBUTING.md before submitting. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
I want to fix #4915 which fixes the OCSF 1.8.0 formatting issues. Specifically, for supervisor events, I moved
containertodevice.container. For gateway events, I putcontainerunderresources. For authentication, there was nocontainerinformation included. I changed the Event data structures and theEventContextand builders. Sinceimageobjects require theuidinformation, I used existing docker and podman codes to fetch the uid information.For Kubernetes, the runtime image ID is not available when Supervisor registration is created. I omit the image field for now. A follow-up PR may implement this asynchronously. Also, I omit image when there isn't one.
I also updated the documentation to reflect this updated OCSF data. For verification, I added tests for this new format and uid fetching.
Why this change?
The top-level field
containeris undefined in OCSF 1.8.0 event classes. Strict consumers will not accept these records. I updated the design as suggested and with minimal changes.Checklist
All reactions