From 0d6cb1452c4ad67e8656a0b65ca0416e7fc8ad8c Mon Sep 17 00:00:00 2001
From: Fredrik Bagge Carlson <baggepinnen@gmail.com>
Date: Thu, 14 May 2026 15:38:21 +0200
Subject: [PATCH] make use of explicit rather than implicit imports of symbols

To prevent future breakage from name clashes introduced by modules
we import exporting new names. Symbol lists derived from
ExplicitImports.print_explicit_imports.

Also drops stale explicit imports flagged by ExplicitImports:
- BlasFloat (top-level ControlSystems)
- PartitionedStateSpace (top-level timeresp)
- issiso (top-level ControlSystems)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../src/ControlSystemsBase.jl                 | 32 ++++++++++++-------
 src/ControlSystems.jl                         | 19 +++++------
 src/timeresp.jl                               |  2 +-
 3 files changed, 32 insertions(+), 21 deletions(-)

diff --git a/lib/ControlSystemsBase/src/ControlSystemsBase.jl b/lib/ControlSystemsBase/src/ControlSystemsBase.jl
index 2524e4ac3..bfe4f123a 100644
--- a/lib/ControlSystemsBase/src/ControlSystemsBase.jl
+++ b/lib/ControlSystemsBase/src/ControlSystemsBase.jl
@@ -131,26 +131,36 @@ export  LTISystem,
         add_output
 
 
-using RecipesBase, LinearAlgebra
 import Polynomials
-import Polynomials: Polynomial, coeffs
+import Polynomials: Polynomial, coeffs, conv # TODO: replace this internal function with something public
 import Base: +, -, *, /, (==), (!=), isapprox, convert, promote_op
 import Base: getproperty, getindex
 import Base: exp # for exp(-s)
 import LinearAlgebra: BlasFloat
 import Hungarian
+import MatrixPencils
+import Printf
+import Printf: @printf, @sprintf
 
 export lyap # Make sure LinearAlgebra.lyap is available
 export plyap
-import Printf
-import Printf: @printf, @sprintf
-import Polynomials: conv # TODO: replace this internal function with something public
-using ForwardDiff
-import MatrixPencils
-using MacroTools
-using MatrixEquations
-using UUIDs # to load Plots in gangoffourplot
-using StaticArraysCore
+
+# Explicit imports — only the symbols actually used in this module.
+# Prevents future breakage from upstream packages exporting new names.
+# Derived from `ExplicitImports.print_explicit_imports(ControlSystemsBase)`.
+using ForwardDiff: ForwardDiff
+using LinearAlgebra: LinearAlgebra, Adjoint, ColumnNorm, Diagonal, I, LAPACK,
+                     Symmetric, UniformScaling, UpperHessenberg, cholesky,
+                     cond, diag, diagind, diagm, eigen, eigvals, eigvals!,
+                     factorize, hessenberg, isdiag, ishermitian, isposdef,
+                     issuccess, ldiv!, lmul!, lu, lu!, lyap, mul!, norm,
+                     opnorm, pinv, qr, rank, rdiv!, schur, schur!, svd!,
+                     svdvals, svdvals!, tr
+using MacroTools: MacroTools
+using MatrixEquations: MatrixEquations, arec, ared, lyapc, lyapd, plyapc, plyapd
+using RecipesBase: RecipesBase, @recipe, @series, @userplot
+using StaticArraysCore: StaticArraysCore, SArray, SMatrix, SVector, SizedArray
+using UUIDs: UUIDs, UUID # to load Plots in gangoffourplot
 
 abstract type AbstractSystem end
 
diff --git a/src/ControlSystems.jl b/src/ControlSystems.jl
index 426b37729..5b62c898d 100644
--- a/src/ControlSystems.jl
+++ b/src/ControlSystems.jl
@@ -1,20 +1,21 @@
 module ControlSystems
 
-using Reexport
+using Reexport: Reexport, @reexport
 @reexport using ControlSystemsBase
-using ControlSystemsBase: issiso, ninputs, noutputs, nstates, numeric_type
+# Explicit imports — only the symbols actually used in this module.
+# Derived from `ExplicitImports.print_explicit_imports(ControlSystems)`.
+using ControlSystemsBase: ControlSystemsBase, AbstractStateSpace, Continuous,
+                          c2d, iscontinuous, ninputs, noutputs, nstates, numeric_type
 import DiffEqBase
 
-
-using LinearAlgebra
+using LinearAlgebra: LinearAlgebra, diagind, mul!
 import OrdinaryDiffEq
-import LinearAlgebra: BlasFloat
 import DiffEqCallbacks: SavingCallback, SavedValues
 import DelayDiffEq
-using SparseArrays
-using StaticArrays
-using RecipesBase
-using Printf
+using SparseArrays: SparseArrays
+using StaticArrays: StaticArrays
+using RecipesBase: RecipesBase
+using Printf: Printf
 
 export Simulator
 
diff --git a/src/timeresp.jl b/src/timeresp.jl
index 6b3c61966..75156de8d 100644
--- a/src/timeresp.jl
+++ b/src/timeresp.jl
@@ -1,6 +1,6 @@
 import OrdinaryDiffEq: ODEProblem, Tsit5, solve
 import OrdinaryDiffEqLowOrderRK: BS3
-import ControlSystemsBase: lsim, step, impulse, HammersteinWienerSystem, DelayLtiSystem, PartitionedStateSpace, SimResult
+import ControlSystemsBase: lsim, step, impulse, HammersteinWienerSystem, DelayLtiSystem, SimResult
 import DelayDiffEq: MethodOfSteps
 # Function for DifferentialEquations lsim
 """