Skip to content

Remove invoke#348

Merged
aplavin merged 1 commit into
JuliaArrays:masterfrom
ptiede:ptiede-invoke
Mar 26, 2026
Merged

Remove invoke#348
aplavin merged 1 commit into
JuliaArrays:masterfrom
ptiede:ptiede-invoke

Conversation

@ptiede

@ptiede ptiede commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Using invoke in the SA extension is a little strange and is creating a StackOverflow in Reactant land. This removes the invoke and tries to be a little more explicit about what we are calling here.

@ptiede

ptiede commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

pre error appears to be independent from this PR

@aplavin

aplavin commented Mar 25, 2026

Copy link
Copy Markdown
Member

invoke support seems a Reactant-specific limitation, but I don't have anything against this PR – will merge unless anyone objects
code readable both before and after

@aplavin aplavin merged commit d10d650 into JuliaArrays:master Mar 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants