Repository navigation
Complete traversal of structured DDL children - #2738
Merged
manticore-projects merged 3 commits intoOct 11, 2026
Merged
manticore-projects merged 3 commits into
manticore-projects merged 3 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
marked this pull request as ready for review
October 1, 2026 15:20
This was referenced Oct 2, 2026
Contributor
|
Please resolve conflicts. |
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make visitor-based analysis and validation reach structured DDL children while preserving the distinction between stored schema definitions and executed statements.
Current design (As-is)
Several DDL nodes already expose structured expressions and tables, but the default statement visitor does not traverse them. INSERT loses the caller's context when visiting its SELECT, and VALUES traversal omits WITH items, ordering and pagination children.
Target design (To-be)
Connect relation and policy alterations, statistics, foreign-data objects, rules, notifications and collations to the configured child visitors. Preserve the original context through rule actions, INSERT and VALUES descendants. Extend expression validation for relation alterations, policies and statistics.
Keep stored rule actions and policy predicates classified as schema definitions in feature analysis. Preserve existing parser result classes and public signatures; grammar and dialect acceptance are unchanged.
Validation
After merging master at
40ed289b, the full Java 17 Gradlecheckpassed: 9,857 tests total, 9,832 passed, 25 skipped, zero failures. Grammar choice-conflict checks, Spotless, Checkstyle, PMD, SpotBugs and coverage verification passed. Regression tests cover child traversal, context propagation, validation and feature classification.GitHub CI at
c13f7ee9also passes: Codacy, grammar conflicts, and Gradle/Maven checks on Linux, macOS and Windows.