Skip to content

Complete traversal of structured DDL children - #2738

Merged
manticore-projects merged 3 commits into
JSQLParser:masterfrom
minleejae:refactor/ddl-visitors-20261001
Oct 11, 2026
Merged

manticore-projects merged 3 commits into
JSQLParser:masterfrom
minleejae:refactor/ddl-visitors-20261001

Conversation

@minleejae

@minleejae minleejae commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Purpose

Make visitor-based analysis and validation reach structured DDL children while preserving the distinction between stored schema definitions and executed statements.

Current design (As-is)

Several DDL nodes already expose structured expressions and tables, but the default statement visitor does not traverse them. INSERT loses the caller's context when visiting its SELECT, and VALUES traversal omits WITH items, ordering and pagination children.

Target design (To-be)

Connect relation and policy alterations, statistics, foreign-data objects, rules, notifications and collations to the configured child visitors. Preserve the original context through rule actions, INSERT and VALUES descendants. Extend expression validation for relation alterations, policies and statistics.

Keep stored rule actions and policy predicates classified as schema definitions in feature analysis. Preserve existing parser result classes and public signatures; grammar and dialect acceptance are unchanged.

Validation

After merging master at 40ed289b, the full Java 17 Gradle check passed: 9,857 tests total, 9,832 passed, 25 skipped, zero failures. Grammar choice-conflict checks, Spotless, Checkstyle, PMD, SpotBugs and coverage verification passed. Regression tests cover child traversal, context propagation, validation and feature classification.

GitHub CI at c13f7ee9 also passes: Codacy, grammar conflicts, and Gradle/Maven checks on Linux, macOS and Windows.

Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
@minleejae
minleejae marked this pull request as ready for review October 1, 2026 15:20
@manticore-projects

Copy link
Copy Markdown
Contributor

Please resolve conflicts.

Signed-off-by: minleejae <mmj9808@gmail.com>
@manticore-projects
manticore-projects merged commit 1b2cf7a into JSQLParser:master Oct 11, 2026
10 checks passed
@manticore-projects

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants