Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Practice TDD#1214
Open
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Practice TDD#1214mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
mahmoudshaabo1984 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
mahmoudshaabo1984
added
the
Needs Review
cjyuan
reviewed
Mar 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Code looks good. I just have some suggestions for some of the test descriptions.
-
You missed updating
count.test.js.
Comment on lines
+27
to
+31
| test("should append 'th' for 11, 12, and 13", () => { | ||
| expect(getOrdinalNumber(11)).toEqual("11th"); | ||
| expect(getOrdinalNumber(12)).toEqual("12th"); | ||
| expect(getOrdinalNumber(13)).toEqual("13th"); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could better update the description and include tests to cover "numbers ending with 11, 12, 13" and not just the three numbers, 11, 12, 13.
Comment on lines
+34
to
37
| test("should append 'th' for other numbers", () => { | ||
| expect(getOrdinalNumber(4)).toEqual("4th"); | ||
| expect(getOrdinalNumber(10)).toEqual("10th"); | ||
| }); |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... other numbers", it may be unclear what "other numbers" actually refers to.
Can you revise the test description to make it more informative?
cjyuan
added
Reviewed
Contributor
|
In the PR description, the checkboxes are currently marked as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] I have tested my changes
[x] My changes follow the style guide
[x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[x] My changes meet the requirements of the task
PR Title:
Sheffield | 26-ITP-Jan | Mahmoud Shaabo | Sprint 3 | Practice TDD
Summary of work:
Completed all mandatory TDD exercises in the 2-practice-tdd directory.
Successfully implemented logic for the following using TDD (Red-Green-Refactor):
count.js: Created a function to count occurrences of a character in a string.
repeat-str.js: Implemented string repetition with a guard clause for negative numbers and the .repeat() method.
get-ordinal-number.js: Solved the complex logic for English ordinal numbers, including specific handling for 11th, 12th, and 13th.
Verified that all 5 tests passed successfully using npm test.
Personal Note for CJ:
Hi CJ,
Following your previous feedback, I have ensured that all checkboxes now use the correct - [x] syntax.
This "Practice TDD" assignment was a significant milestone for me. Navigating the test failures with NVDA and then writing the logic to make them pass helped me deeply understand the TDD cycle. I'm especially pleased with how I handled the edge cases for the ordinal numbers!
Best regards,
Mahmoud Shaabo