Refactor time conversion logic and enhance test coverage for edge cases

Author: chefmatthaus-hub

format-clock-edge-cases/timeConverter.js

@@ -1,11 +1,17 @@
 function formatAs12HourClock(time) {
 
   const hours = Number(time.slice(0, 2));
+  const minutes = time.slice(2);
+
+  if (hours === 24) {
+    return `12${minutes} am`
+  }
 
   if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+    return `${hours - 12}${minutes} pm`;
   }
+
   return `${time} am`;
 }
 
-export {formatAs12HourClock};
+export {formatAs12HourClock};

format-clock-edge-cases/timeConverter.test.js

@@ -2,10 +2,54 @@ import {formatAs12HourClock} from "./timeConverter.js";
 import assert from "node:assert";
 import test from "node:test";
 
-test("correctly convert time after 12:00", function(){
+test("correctly convert hours after 12:00", () => {
     assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
 });
 
-test("can correctly convert morning time", function() {
+test("correctly convert minutes after 12:00", () => {
+    assert.equal(formatAs12HourClock("23:53"), "11:53 pm");
+});
+
+test("can correctly convert morning time", () => {
     assert.equal(formatAs12HourClock("08:00"), "08:00 am");
 });
+
+test("can correctly convert morning time minutes", () => {
+    assert.equal(formatAs12HourClock("08:30"), "08:30 am");
+});
+
+test("can correctly convert morning time minutes", () => {
+    assert.equal(formatAs12HourClock("08:34"), "08:34 am");
+});
+
+test("can successfully convert midnight time", () =>
+    assert.equal(formatAs12HourClock("24:00"), "12:00 am"));
+
+
+
+/*
+Edge cases:
+Correctly convert hours after 12:00
+Input | Expected
+23:00   11:00 pm
+
+Correctly convert afternoon hours and minutes
+Input | Expected
+23:00   11:53 pm
+
+Correctly convert morning time and minutes
+Input | Expected
+08:00   08:00 am
+
+Correctly convert morning time and minutes
+Input | Expected
+08:30   08:30 am
+
+Correctly convert morning time and minutes
+Input | Expected
+08:34   08:34 am
+
+Correctly convert midnight time
+Input | Expected
+24:00   12:00 am
+*/