Repository navigation
fix(desktop-gpui): count characters, not bytes, at caption boundaries - #2685
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the unicode caption segmentation case from the verify expectations. caption chunking avoids ending a caption on a weak one letter word, but it checked the length in bytes, so a one letter word outside ascii like the french "à" counted as two letters and a caption could end on it.
now it counts characters, which is what the reference model already does. the tests run "à", a decomposed "à" and a cjk character through both the chunk end and short tail paths, the xfail is removed, and the full ascii and unicode segmentation oracles pass.
🤖 Generated with Claude Code


Confidence Score: 5/5
This PR appears safe to merge.Summary
Changes GPUI caption boundaries to count Unicode characters instead of bytes.
No actionable issues found. Tests were inspected, not run.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): count Unicode charact..." · Reviewed by Greptile