Open
Conversation
…ject Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…kwards-compatible caption migration Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…pipelines Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…ildup Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…line Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…ll drag/resize/split support Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
…board settings store Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
… generation Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds keyboard press recording and display, and migrates captions and keyboard presses to interactive timeline tracks for improved editing and visualization.
Greptile Summary
This PR introduces keyboard press recording and display, and migrates both captions and keyboard presses to interactive timeline tracks for improved editing and visualization.
Major Changes:
device_querycrate, capturing key down/up events with timestampscrates/project/src/keyboard.rsmodule implementing intelligent grouping of key events (handles rapid typing, modifiers, special keys, backspace, and command combinations)crates/rendering/src/layers/keyboard.rs) with fade animations and bounce effectsArchitecture:
cursor.rspolls keyboard state viadevice_query, writeskeyboard.jsonper segmentgenerate_keyboard_segmentscommand aggregates events and groups them using configurable thresholdsConfidence Score: 5/5
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Recording Start] --> B[cursor.rs: Poll keyboard via device_query] B --> C[Track key down/up events with timestamps] C --> D[Flush to keyboard.json per segment] D --> E[Recording Stop] E --> F[Editor: Load keyboard.json from segments] F --> G[generate_keyboard_segments command] G --> H[Group events by threshold] H --> I[Apply modifier/special key logic] I --> J[Create KeyboardTrackSegments] J --> K[Timeline: Display as interactive track] K --> L[User edits: drag, resize, split] J --> M[Render Pipeline] M --> N[KeyboardLayer.prepare] N --> O[Find active segment for current time] O --> P[Calculate fade and bounce] P --> Q[Render text with glyphon] Q --> R[Render background box with WGPU] R --> S[Final video frame]Last reviewed commit: 572802f