Network Weathermap 2.0, maintained by The Cacti Group. Based on the original PHP Network
Weathermap and manual by Howard Jones, © 2005–2019; Cacti fork contributions © 2022–2026
diff --git a/tests/Browser/DocsExampleHoverTest.cjs b/tests/Browser/DocsExampleHoverTest.cjs
new file mode 100644
index 00000000..f813b0e5
--- /dev/null
+++ b/tests/Browser/DocsExampleHoverTest.cjs
@@ -0,0 +1,68 @@
+const {JSDOM, VirtualConsole} = require('jsdom');
+const jquery = require('jquery');
+const fs = require('node:fs');
+const path = require('node:path');
+const vm = require('node:vm');
+const assert = require('node:assert/strict');
+
+/**
+ * Load a page from disk with its scripts and subresources enabled, recording load errors.
+ *
+ * @param {string} file Absolute path of the HTML page.
+ * @returns {Promise<{dom: JSDOM, errors: string[]}>} The loaded page and any resource or script errors.
+ */
+async function loadPage(file) {
+ const errors = [];
+ const virtualConsole = new VirtualConsole();
+ virtualConsole.on('jsdomError', (error) => errors.push(error.message));
+ virtualConsole.on('error', (message) => errors.push(String(message)));
+ const dom = await JSDOM.fromFile(file, {runScripts: 'dangerously', resources: 'usable', virtualConsole});
+ await new Promise((resolve) => dom.window.addEventListener('load', resolve));
+ return {dom, errors};
+}
+
+(async () => {
+ const example = path.join(__dirname, '../../docs/example/example.html');
+ const {dom, errors} = await loadPage(example);
+ const doc = dom.window.document;
+ const links = [...doc.querySelectorAll('area[id^="LINK:"]')];
+
+ assert.equal(doc.querySelectorAll('script').length, 0, 'static example loads no script');
+ assert.equal(typeof dom.window.overlib, 'undefined', 'overLIB is not defined');
+ assert.ok(links.length > 0, 'example has link areas');
+ for (const area of links) {
+ assert.ok(area.title.trim() !== '', `${area.id} has a hover caption`);
+ assert.deepEqual(area.getAttributeNames().filter((name) => name.startsWith('on')), [], `${area.id} has no inline handler`);
+ area.dispatchEvent(new dom.window.MouseEvent('mouseover', {bubbles: true}));
+ area.dispatchEvent(new dom.window.MouseEvent('mouseout', {bubbles: true}));
+ }
+ const image = doc.getElementById('wmapimage').getAttribute('src');
+ assert.ok(fs.existsSync(path.join(path.dirname(example), image)), 'map image is shipped');
+ assert.deepEqual(errors, [], 'page loads and hovers without errors');
+
+ // HTMLSTYLE overlib output is now rendered by the viewer from data-hover, not by overLIB.
+ const viewer = new JSDOM(' ', {runScripts: 'outside-only', url: 'https://cacti.example/cacti/plugins/weathermap/view.php'});
+ const w = viewer.window;
+ const $ = jquery(w);
+ let options;
+ w.$ = $;
+ $.fn.tooltip = function (value) {
+ if (value === 'instance') return undefined;
+ options = value;
+ return this;
+ };
+ vm.runInContext(fs.readFileSync(path.join(__dirname, '../../js/weathermap.js'), 'utf8'), viewer.getInternalVMContext());
+ await new Promise((resolve) => $(resolve));
+ await new Promise((resolve) => setImmediate(resolve));
+ const area = $('area');
+ area.attr('data-hover', Buffer.from("
").toString('base64'));
+ let output;
+ options.content.call(area[0], (html) => (output = html));
+ assert.equal($(output).find('img').attr('src'), 'graph_image.png');
+ assert.match($(output).text(), /sync-core/);
+ assert.equal(typeof w.overlib, 'undefined');
+ console.log('Docs example hover captions and viewer hover content without overLIB PASS');
+})().catch((error) => {
+ console.error(error);
+ process.exit(1);
+});
diff --git a/tests/Browser/EditorIconPickerTest.cjs b/tests/Browser/EditorIconPickerTest.cjs
index 25e08843..07024598 100644
--- a/tests/Browser/EditorIconPickerTest.cjs
+++ b/tests/Browser/EditorIconPickerTest.cjs
@@ -51,12 +51,4 @@ let escaped=0;$(w.document).on('keydown',e=>{if(e.key==='Escape')escaped++});
$('#wm-icon-picker summary').trigger($.Event('keydown',{key:'Escape'}));assert.equal(escaped,1,'closed picker lets Escape close its parent dialog');
$('input[type=search]').val('nothing-matches').trigger('input');
assert.equal($('.wm-icon-count').text(),'No matching icons');
-const overlib=fs.readFileSync(path.join(__dirname,'../../docs/example/overlib.js'),'utf8');
-const escapeStart=overlib.indexOf('function escSglQuote('),escapeEnd=overlib.indexOf('\n}',escapeStart)+2;
-w.eval(overlib.slice(escapeStart,escapeEnd));
-assert.equal(w.escSglQuote("O'Brien"),"O\\'Brien");
-assert.equal(w.escSglQuote('back\\slash'),'back\\\\slash');
-assert.equal(w.escSglQuote('line\nbreak'),'line\\nbreak');
-assert.equal(w.escSglQuote('line\u2028break'),'line\\u2028break');
-assert.equal(w.escSglQuote('line\u2029break'),'line\\u2029break');
console.log('Icon picker selection, search, reopening and Escape PASS');
diff --git a/tests/Browser/README.md b/tests/Browser/README.md
index cc58312b..522f0db7 100644
--- a/tests/Browser/README.md
+++ b/tests/Browser/README.md
@@ -16,3 +16,7 @@ Run it with the same dependencies and `CACTI_JS_DIR=/path/to/cacti/include/js`.
`EditorPickerReopeningTest.cjs` uses the same dependencies and `CACTI_JS_DIR`.
It exercises real jQuery UI focus/blur timing, Browse all, input/arrow reopening,
changing an existing selection and typed filtering in both link and node pickers.
+
+`DocsExampleHoverTest.cjs` loads `docs/example/example.html` with its subresources and
+checks that its hover captions work without overLIB, then feeds engine-style
+`data-hover` content through `js/weathermap.js`. It needs only jsdom and jQuery.
diff --git a/tests/E2E/DocumentationExampleHoverTest.php b/tests/E2E/DocumentationExampleHoverTest.php
new file mode 100644
index 00000000..0ddc2e1d
--- /dev/null
+++ b/tests/E2E/DocumentationExampleHoverTest.php
@@ -0,0 +1,207 @@
+assertSame('overlib', $map->htmlstyle);
+ $this->assertSame(0, $GLOBALS['weathermap_warncount'], 'example.conf renders without warnings');
+
+ foreach ([$fragment, $standalone] as $html) {
+ $this->assertStringNotContainsStringIgnoringCase('overlib(', $html);
+ $this->assertStringNotContainsStringIgnoringCase('overlib.js', $html);
+ $this->assertStringNotContainsString('overDiv', $html);
+ }
+
+ $areas = self::linkAreas(self::parse($fragment));
+ $captions = [];
+ $this->assertNotEmpty($areas, 'example links produce image-map areas');
+
+ foreach ($areas as $area) {
+ foreach ($area->attributes as $attribute) {
+ $this->assertStringStartsNotWith('on', strtolower($attribute->name), 'no inline event handlers on ' . $area->getAttribute('id'));
+ }
+
+ $name = $area->getAttribute('data-caption');
+ $link = $map->links[$name] ?? null;
+ $this->assertNotNull($link, 'caption names a configured link');
+ $captions[$name] = true;
+
+ $hover = base64_decode($area->getAttribute('data-hover'), true);
+ $this->assertIsString($hover, 'data-hover is valid base64');
+ $images = self::parse($hover)->getElementsByTagName('img');
+ $this->assertSame(count($link->overliburl[IN]), $images->length, "$name hover shows every OVERLIBGRAPH");
+
+ foreach ($images as $index => $image) {
+ $this->assertSame('395', $image->getAttribute('data-width'));
+ $this->assertSame('153', $image->getAttribute('data-height'));
+ $this->assertStringStartsWith($link->overliburl[IN][$index], $image->getAttribute('src'));
+ }
+ }
+
+ // The static historical page uses the same captions as plain title tooltips.
+ $static = self::parse(file_get_contents($plugin . '/docs/example/example.html'));
+ $titles = [];
+
+ foreach (self::linkAreas($static, 'title') as $area) {
+ $titles[$area->getAttribute('title')] = true;
+ }
+
+ ksort($captions);
+ ksort($titles);
+ $this->assertSame(array_keys($captions), array_keys($titles), 'static example titles match engine captions');
+ $this->assertSame(0, $static->getElementsByTagName('script')->length, 'static example loads no script');
+ }
+
+ /** The standalone page only references scripts that the plugin ships or Cacti provides. */
+ #[RunInSeparateProcess]
+ #[PreserveGlobalState(false)]
+ public function testStandaloneExampleReferencesOnlyAvailableScripts(): void {
+ $plugin = dirname(__DIR__, 2);
+ [, , $standalone] = self::renderExample($plugin);
+ $scripts = self::parse($standalone)->getElementsByTagName('script');
+ $cactiProvided = ['/cacti/include/js/jquery.js', '/cacti/include/js/jquery-ui.js', '/cacti/include/js/pace.js'];
+ $pluginScriptPrefix = '/cacti/plugins/weathermap/';
+ $this->assertGreaterThan(0, $scripts->length);
+
+ foreach ($scripts as $script) {
+ $src = $script->getAttribute('src');
+
+ if (str_starts_with($src, $pluginScriptPrefix)) {
+ $this->assertFileExists($plugin . '/' . substr($src, strlen($pluginScriptPrefix)), "$src is shipped");
+ } else {
+ $this->assertContains($src, $cactiProvided, "$src is a Cacti core script");
+ }
+ }
+ }
+
+ /**
+ * Render docs/example/example.conf through ReadConfig, DrawMap and MakeHTML.
+ *
+ * The engine is constructed in the plugin root so data-source plugins load, then
+ * reads the example from its own directory so its relative fonts and background resolve.
+ * ReadData is skipped: the example's RRD targets are not shipped.
+ *
+ * @param string $plugin Absolute plugin root.
+ *
+ * @return array{0: WeatherMap, 1: string, 2: string} The map, the viewer fragment and the standalone page.
+ */
+ private static function renderExample(string $plugin): array {
+ chdir($plugin);
+ require_once $plugin . '/setup.php';
+ require_once $plugin . '/lib/WeatherMap.class.php';
+
+ if (!function_exists('get_selected_theme')) {
+ /**
+ * Stand in for Cacti's theme lookup used by standalone HTML.
+ *
+ * @return string The theme directory name.
+ */
+ function get_selected_theme() {
+ return 'modern';
+ }
+ }
+
+ $GLOBALS['weathermap_warncount'] = 0;
+ $map = new WeatherMap();
+ $map->rrdtool = PHP_BINARY;
+ chdir($plugin . '/docs/example');
+
+ if (!$map->ReadConfig('example.conf')) {
+ throw new RuntimeException('Cannot parse docs/example/example.conf');
+ }
+
+ // DrawMap picks the image writer from the extension, so the temporary file needs .png.
+ $temporary = tempnam(sys_get_temp_dir(), 'wm-example-');
+ $output = $temporary . '.png';
+ unlink($temporary);
+
+ try {
+ $map->DrawMap($output);
+ } finally {
+ if (is_file($output)) {
+ unlink($output);
+ }
+ }
+
+ $map->imageuri = 'example.png';
+
+ return [$map, $map->MakeHTML(), $map->MakeHTML('weathermap_example_imap', true)];
+ }
+
+ /**
+ * Parse an HTML fragment or page without emitting libxml warnings.
+ *
+ * @param string $html Markup to parse.
+ *
+ * @return DOMDocument The parsed document.
+ */
+ private static function parse(string $html): DOMDocument {
+ $document = new DOMDocument();
+ $previous = libxml_use_internal_errors(true);
+ $document->loadHTML('' . $html);
+ libxml_clear_errors();
+ libxml_use_internal_errors($previous);
+
+ return $document;
+ }
+
+ /**
+ * Return the image-map areas for links that carry a hover attribute.
+ *
+ * @param DOMDocument $document Parsed page.
+ * @param string $attribute Attribute that marks a hover area.
+ *
+ * @return DOMElement[] Matching LINK areas.
+ */
+ private static function linkAreas(DOMDocument $document, string $attribute = 'data-hover'): array {
+ $areas = [];
+
+ foreach ($document->getElementsByTagName('area') as $area) {
+ if (str_starts_with($area->getAttribute('id'), 'LINK:') && $area->hasAttribute($attribute)) {
+ $areas[] = $area;
+ }
+ }
+
+ return $areas;
+ }
+}
diff --git a/tests/Unit/LegacyOverlibRetiredTest.php b/tests/Unit/LegacyOverlibRetiredTest.php
new file mode 100644
index 00000000..5e6b0591
--- /dev/null
+++ b/tests/Unit/LegacyOverlibRetiredTest.php
@@ -0,0 +1,109 @@
+isFile() && in_array(strtolower($file->getExtension()), $extensions, true)) {
+ $files[] = substr($file->getPathname(), strlen($root) + 1);
+ }
+ }
+ }
+
+ sort($files);
+
+ return $files;
+}
+
+it('no longer ships the overLIB library', function (): void {
+ $root = dirname(__DIR__, 2);
+
+ $bundled = array_filter(wm_retired_overlib_sources(['docs', 'js'], ['js']), fn ($file) => stripos(basename($file), 'overlib') !== false);
+
+ expect(file_exists($root . '/docs/example/overlib.js'))->toBeFalse()
+ ->and($bundled)->toBe([]);
+});
+
+it('keeps dynamic code evaluation out of shipped JavaScript and documentation', function (string $file): void {
+ $source = file_get_contents(dirname(__DIR__, 2) . '/' . $file);
+
+ expect(preg_match('/\beval\s*\(/', $source))->toBe(0, "$file calls eval()")
+ ->and(preg_match('/\bnew\s+Function\s*\(/', $source))->toBe(0, "$file constructs a Function from a string")
+ ->and(preg_match('/\bset(?:Timeout|Interval)\s*\(\s*[\'"`]/', $source))->toBe(0, "$file passes a code string to a timer");
+})->with(fn () => wm_retired_overlib_sources(['js', 'docs'], ['js', 'html', 'htm']));
+
+it('does not reference overlib.js from any shipped page or HTML writer', function (string $file): void {
+ $source = file_get_contents(dirname(__DIR__, 2) . '/' . $file);
+
+ expect(preg_match('/src\s*=\s*\\\\?[\'"]?[^\'"\s>]*overlib\.js/i', $source))->toBe(0, "$file loads overlib.js")
+ ->and(preg_match('/\b(?:overlib|nd)\s*\(\s*[^)]/i', $source) + preg_match('/return\s+nd\s*\(\s*\)/i', $source))->toBe(0, "$file calls overLIB functions");
+})->with(fn () => array_merge(
+ ['weathermap', 'setup.php', 'weathermap-cacti-plugin.php', 'weathermap-cacti-plugin-editor.php'],
+ wm_retired_overlib_sources(['lib', 'cli', 'js', 'docs'], ['php', 'js', 'html', 'htm'])
+));
+
+it('loads only scripts that exist from bundled documentation pages', function (string $file): void {
+ $root = dirname(__DIR__, 2);
+ $document = new DOMDocument();
+ $previous = libxml_use_internal_errors(true);
+ $document->loadHTML(file_get_contents($root . '/' . $file));
+ libxml_clear_errors();
+ libxml_use_internal_errors($previous);
+ $missing = [];
+ $handlers = [];
+
+ foreach ($document->getElementsByTagName('script') as $script) {
+ $src = $script->getAttribute('src');
+
+ if ($src !== '' && !preg_match('#^(?:[a-z]+:)?//#i', $src) && !is_file(dirname($root . '/' . $file) . '/' . strtok($src, '?#'))) {
+ $missing[] = $src;
+ }
+ }
+
+ foreach ($document->getElementsByTagName('*') as $element) {
+ foreach ($element->attributes as $attribute) {
+ if (str_starts_with(strtolower($attribute->name), 'on') && preg_match('/\\b(?:overlib|nd)\\s*\\(/i', $attribute->value)) {
+ $handlers[] = $attribute->value;
+ }
+ }
+ }
+
+ expect($missing)->toBe([], "$file loads missing scripts")
+ ->and($handlers)->toBe([], "$file still calls overLIB");
+})->with(fn () => wm_retired_overlib_sources(['docs'], ['html', 'htm']));
From 3b19a5c295c8ff4b7642ba08b80694212986b985 Mon Sep 17 00:00:00 2001
From: Thomas Vincent
Date: Sun, 8 Nov 2026 18:39:52 -0800
Subject: [PATCH 3/7] test: ignore libpng's sRGB profile warning in the docs
example render
Newer libpng, as used by the PHP 8.6 CI leg, warns about the sRGB profile
embedded in docs/example/my_router.png. Ignore only that message while the
example is read and drawn; any other warning still fails the test.
Signed-off-by: Thomas Vincent
---
tests/E2E/DocumentationExampleHoverTest.php | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/tests/E2E/DocumentationExampleHoverTest.php b/tests/E2E/DocumentationExampleHoverTest.php
index 0ddc2e1d..a172476f 100644
--- a/tests/E2E/DocumentationExampleHoverTest.php
+++ b/tests/E2E/DocumentationExampleHoverTest.php
@@ -146,8 +146,21 @@ function get_selected_theme() {
$map->rrdtool = PHP_BINARY;
chdir($plugin . '/docs/example');
- if (!$map->ReadConfig('example.conf')) {
- throw new RuntimeException('Cannot parse docs/example/example.conf');
+ // Newer libpng warns about the sRGB profile embedded in the example's
+ // icon. That is a property of the shipped image, not of the engine, so
+ // only that message is ignored; any other warning still fails the test.
+ set_error_handler(static function ($errno, $message) {
+ return strpos($message, 'libpng warning: iCCP:') !== false;
+ }, E_WARNING);
+
+ try {
+ if (!$map->ReadConfig('example.conf')) {
+ throw new RuntimeException('Cannot parse docs/example/example.conf');
+ }
+ } catch (Throwable $e) {
+ restore_error_handler();
+
+ throw $e;
}
// DrawMap picks the image writer from the extension, so the temporary file needs .png.
@@ -158,6 +171,8 @@ function get_selected_theme() {
try {
$map->DrawMap($output);
} finally {
+ restore_error_handler();
+
if (is_file($output)) {
unlink($output);
}
From f14e944f73de4d51802caedbc8532b2098d802e7 Mon Sep 17 00:00:00 2001
From: Thomas Vincent
Date: Sun, 8 Nov 2026 18:43:11 -0800
Subject: [PATCH 4/7] test: mark the docs hover test's script load as reviewed
The test loads the repository's own js/weathermap.js into its jsdom
context through vm.runInContext, as jsdom documents.
Signed-off-by: Thomas Vincent
---
tests/Browser/DocsExampleHoverTest.cjs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/Browser/DocsExampleHoverTest.cjs b/tests/Browser/DocsExampleHoverTest.cjs
index f813b0e5..90e1b4ca 100644
--- a/tests/Browser/DocsExampleHoverTest.cjs
+++ b/tests/Browser/DocsExampleHoverTest.cjs
@@ -51,7 +51,8 @@ async function loadPage(file) {
options = value;
return this;
};
- vm.runInContext(fs.readFileSync(path.join(__dirname, '../../js/weathermap.js'), 'utf8'), viewer.getInternalVMContext());
+ // Loads the repository's own viewer script into the test DOM, as jsdom documents.
+ vm.runInContext(fs.readFileSync(path.join(__dirname, '../../js/weathermap.js'), 'utf8'), viewer.getInternalVMContext()); // NOSONAR
await new Promise((resolve) => $(resolve));
await new Promise((resolve) => setImmediate(resolve));
const area = $('area');
From 720d3dbb02ca1b2be4919912f87d15b1f9900691 Mon Sep 17 00:00:00 2001
From: Thomas Vincent
Date: Sun, 8 Nov 2026 18:47:54 -0800
Subject: [PATCH 5/7] Revert "test: ignore libpng's sRGB profile warning in the
docs example render"
This reverts commit 3b19a5c295c8ff4b7642ba08b80694212986b985.
Signed-off-by: Thomas Vincent
---
tests/E2E/DocumentationExampleHoverTest.php | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/tests/E2E/DocumentationExampleHoverTest.php b/tests/E2E/DocumentationExampleHoverTest.php
index a172476f..0ddc2e1d 100644
--- a/tests/E2E/DocumentationExampleHoverTest.php
+++ b/tests/E2E/DocumentationExampleHoverTest.php
@@ -146,21 +146,8 @@ function get_selected_theme() {
$map->rrdtool = PHP_BINARY;
chdir($plugin . '/docs/example');
- // Newer libpng warns about the sRGB profile embedded in the example's
- // icon. That is a property of the shipped image, not of the engine, so
- // only that message is ignored; any other warning still fails the test.
- set_error_handler(static function ($errno, $message) {
- return strpos($message, 'libpng warning: iCCP:') !== false;
- }, E_WARNING);
-
- try {
- if (!$map->ReadConfig('example.conf')) {
- throw new RuntimeException('Cannot parse docs/example/example.conf');
- }
- } catch (Throwable $e) {
- restore_error_handler();
-
- throw $e;
+ if (!$map->ReadConfig('example.conf')) {
+ throw new RuntimeException('Cannot parse docs/example/example.conf');
}
// DrawMap picks the image writer from the extension, so the temporary file needs .png.
@@ -171,8 +158,6 @@ function get_selected_theme() {
try {
$map->DrawMap($output);
} finally {
- restore_error_handler();
-
if (is_file($output)) {
unlink($output);
}
From bbcffc40122e02a15e81ec839a3292b20ba15885 Mon Sep 17 00:00:00 2001
From: Thomas Vincent
Date: Sun, 8 Nov 2026 18:48:07 -0800
Subject: [PATCH 6/7] docs: drop the invalid sRGB profile from the example
router icon
libpng 1.6 prints "iCCP: known incorrect sRGB profile" whenever the
example map loads my_router.png, which fails the docs example render on
the PHP 8.6 CI leg. Remove the iCCP chunk; the decoded pixels are
unchanged.
Signed-off-by: Thomas Vincent
---
docs/example/my_router.png | Bin 3904 -> 1255 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/docs/example/my_router.png b/docs/example/my_router.png
index ed111413105cf66bef6172dd3f8b5d457550155e..9ee035e29c8c1a3332d6ca37fb6e2916841d4923 100644
GIT binary patch
delta 11
ScmX>g_ndQr#pa1z>sbIEVFZ`}
delta 2698
zcmV;53U&483BVqZIDZOFX+uL$P-t&-Z*ypGa3D!TLm+T+Z)Rz1WdHzp+MQE(Sd;e_
zKHv9c4^~3h@UfR{fdC>StO&>uS)ve<0AYj>5y@A0LT~suv4>S3ILP<0Bm`DLLvaF4FK%)Nj?Pt*r}7;7Xa9z9H|HZ
zjR63eC`Tj$K!3XcU{!%qECRs70HCZuA}$2Lt^t5qwlYTofV~9(c8*w(4?ti5fSE!p
z%m5%b0suoE6U_r4Oaq`W(!b!TUvP!ENC5!A%azTSOVTqGxRuZvck=My;vwR~Y_URN
z7by^C3FIQ2mzyIKNaq7g&I|wm8u`(|{y0C7=jP<$=6`1AZ142NqW){}Zz4V+@!$Tu
zi~3=fuAC~28EsPoqkpK{9G%|Vj005J}`Hw&=0RYXHq~ibpyyzHQ
zsFW8>#s~laM4*8xut5h5!4#~(4xGUqyucR%VSffhKnx_nJP<+#?5=i
zx(HVZgM=}{CnA%mPqZa^68XeSVKGG0roJ=O`kZsA{w~!BzPm=q|!{oOVI>m_MObMbS
zQlyj;N;PFaO^>2$gY-Gd%Qm(Z8eYv>2*=jns=cMJ`N4THx>VkjAF8G9M07`GWOnM|ey
z)0dgZR4~^v8<}UA514ONSSt1^d=-((5|uiYR+WC0=c-gyb5%dpd8!Lkt5pxHURHgk
zMpd&=yOjAR1s%ETak!GFdam@h^#)@rS0t$wXH+Irf)+G6c;?H29p+V6F6oj{!|o%K3xI)C?d3A#4A
zQM!e?+jY>uuIoY)~6ln+%&eo6EMSt(&dHcAIVA6yg+*DbgwR
zQ*PQZ?ELHs?3(Nb?K$>g_9gah_Rk&691wl!-G{dRHsl(}4
zXB%gsbDi@w7p6;)%MzD%mlsoQr;4X;pL)xc%+^yMd)ZNTI#eJ*$
zO)i@o$z8)e??LqN_gLa_%;TM>o2SC_kmoO6c3xRt`@J4dvz#WL)-Y|z+r(Soy~}%G
zIzByR`p)SCKE^%*pMQFvhrXu1BHul}BYxI?nSKZSp8Grc%l(h|zu|fE7V%C6U;)7a
z8@mESk|3$_Skm
zS{wQ>%qC18))9_|&j{ZTes8AvOzF(F2#DZEY>2oYX&IRp`G0*BDJn9mF6vRVQ*?23
z_bk?|G6C?@kiR8rC
z#65}Qa{}jVnlqf_npBo_W3J`gqPZ95>CVfZcRX1&S&)1zB2~Schd65~Cxg+yU
zRz%j`tk2nT*)2JgoRplSQVnUAv@6#zwiHuJf`1l#y^yd_xUjR>xOiFd;3B_8
zyA~shQx|tGF!j;$
ztoK>JuYXFtYC+Y|hVTuo8}W_h8((co-gKdQYW0rIw9U%R12tha?OV*YtlRRTHly}>
zoqt`+R{gE3x4zjX+Sb3_cYE^=gB=w+-tUy`ytONMS8KgRef4hA?t0jufM;t32jm~jej0UI&kHifN$EH?V5MBa9S!3!a?Q1
zC*P)gd*e{(q0YnH!_D8Bf4B7r>qvPk(mKC&tSzH$pgp0z@92!9ogH2sN4~fJe(y2k
zV|B+hk5`_cohUu=`Q(C=R&z?UQbnZ;IU-!xL
z-hbzhUGThc^dk3S+apRi!(|`JEz}0it
z_}4C7pLxCS#_SunZYJFvxFx#v_;&W~7k3KoOx#_1k9e>AzS{lj2l@}{f3*IwWx#FV
z_+Y?b&%;>{?+yuvp8k~o(}&^GN6bgnBY#FCjgOrl9~%uCz4Bzvli{bbrxVZ0epdf^
z>vOB;-~HnIOV3#R*zgPai_gEVd8zYq@2jb=I>#f&AH2?aJ@Kaetz@;j(q!3lK=n!AhAlF
E1ZAK
Date: Sun, 8 Nov 2026 19:04:42 -0800
Subject: [PATCH 7/7] docs: describe the docs hover check in its own header
Keep tests/Browser/README.md as on develop so this PR does not conflict
with the README rewrite in #333.
Signed-off-by: Thomas Vincent
---
tests/Browser/DocsExampleHoverTest.cjs | 3 +++
tests/Browser/README.md | 4 ----
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/Browser/DocsExampleHoverTest.cjs b/tests/Browser/DocsExampleHoverTest.cjs
index 90e1b4ca..fa29849c 100644
--- a/tests/Browser/DocsExampleHoverTest.cjs
+++ b/tests/Browser/DocsExampleHoverTest.cjs
@@ -1,3 +1,6 @@
+// Loads docs/example/example.html with its subresources, checks that its hover
+// captions work without overLIB, then feeds engine-style data-hover content
+// through js/weathermap.js. Needs only jsdom and jQuery.
const {JSDOM, VirtualConsole} = require('jsdom');
const jquery = require('jquery');
const fs = require('node:fs');
diff --git a/tests/Browser/README.md b/tests/Browser/README.md
index 522f0db7..cc58312b 100644
--- a/tests/Browser/README.md
+++ b/tests/Browser/README.md
@@ -16,7 +16,3 @@ Run it with the same dependencies and `CACTI_JS_DIR=/path/to/cacti/include/js`.
`EditorPickerReopeningTest.cjs` uses the same dependencies and `CACTI_JS_DIR`.
It exercises real jQuery UI focus/blur timing, Browse all, input/arrow reopening,
changing an existing selection and typed filtering in both link and node pickers.
-
-`DocsExampleHoverTest.cjs` loads `docs/example/example.html` with its subresources and
-checks that its hover captions work without overLIB, then feeds engine-style
-`data-hover` content through `js/weathermap.js`. It needs only jsdom and jQuery.