Skip to content

fix(review): refresh staged status before releasing the repository lock - #46

Closed
Bil0000 wants to merge 1 commit into
t3code/jake-review-handoff-busyfrom
t3code/jake-review-staged-status-refresh
Closed

Bil0000 wants to merge 1 commit into
t3code/jake-review-handoff-busyfrom
t3code/jake-review-staged-status-refresh

Conversation

@Bil0000

@Bil0000 Bil0000 commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Hunk staging could finish before the status refresh, allowing a branch switch to overtake that refresh. Wait for local status to refresh inside the existing repository lock. The refresh stays local so it cannot trigger a remote fetch or auto-pull while holding the lock.

Verified: all three focused server RPC tests, native server typecheck, targeted lint and formatting, and normal commit hooks pass. The backport matches the main source patch.

Model: GPT-6. Harness: Codex.

Viewed state shared by the PR diff and file tree

jake-viewed-before

jake-viewed-after

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Sep 13, 2026
@Bil0000
Bil0000 added this pull request to stack #28 September 13, 2026 14:08
@Bil0000 Bil0000 closed this Sep 18, 2026
@Bil0000

Bil0000 commented Sep 18, 2026

Copy link
Copy Markdown
Owner Author

Screenshots for the tree UI update in pingdotgg#11256. This fork stack PR remains closed. The images show only public T3 Code file paths, before and after the layout change in light and dark themes.

jake-tree-style-before

jake-tree-light-1280

jake-tree-dark-1440

@Bil0000

Bil0000 commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Browser evidence for consolidated upstream PR pingdotgg#11256. This fork PR remains closed.

Before: flat comment list. After: grouped review thread, reply editor, Write/Preview, and attachment control. The after screenshot uses a local fixture; source-host writes were intercepted and not sent.

Before: flat comment list

After: grouped thread and reply editor, local fixture

@Bil0000

Bil0000 commented Sep 19, 2026

Copy link
Copy Markdown
Owner Author

Staging screenshots from the earlier app test (September 13), for the consolidated PR pingdotgg#11256. These show fixture data.

Staged changes and find:

Staged changes and find

Unstaged edits made after staging:

Unstaged edits made after staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant