Skip to content

Should ghapi 1.x pin down fastcore <2.0? #218

Description

@krassowski

Currently installing ghapi<2 pulls latest fastcore 2.0 which results in runtime errors:

    return core.GhApi(**kwargs)
           ^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/ghapi/core.py", line 105, in __init__
    funcs_ = L(funcs).starmap(_GhVerb, client=self, kwargs=kwargs)
             ^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/fastcore/basics.py", line 578, in __getattr__
    if attr is not None: return getattr(attr,k)
                                ^^^^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'starmap'

The old version compatibility aside, I am not quite sure if the minimum version required on main is accurate either (should it be 2.0?):

dependencies = ['fastcore>=1.14.5', 'fastspec>=0.1.0']

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions