Skip to content

[PWGJE] Add jetHadronsPID#16012

Open
llorenc-11 wants to merge 29 commits into
AliceO2Group:masterfrom
llorenc-11:PID-Hadrons-in-Jets
Open

[PWGJE] Add jetHadronsPID#16012
llorenc-11 wants to merge 29 commits into
AliceO2Group:masterfrom
llorenc-11:PID-Hadrons-in-Jets

Conversation

@llorenc-11

@llorenc-11 llorenc-11 commented Apr 28, 2026

Copy link
Copy Markdown

The reason for this pull request is to create a new analysis of PID in jets as a student's team with the collaboration of Warsaw University of Technology Physics department .
This is the first pull request from this account, I hope all the technical requirements are met.
If you have any questions, please contact me on leonard.lorenc@cern.ch

@github-actions github-actions Bot added the pwgje label Apr 28, 2026
@github-actions github-actions Bot changed the title [PWGJE] Adding file jetHadronsPID.cxx and it's workflow [PWGJE] Adding file jetHadronsPID.cxx and it's workflow Apr 28, 2026
@github-actions

github-actions Bot commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Apr 28, 2026
Closed
@llorenc-11 llorenc-11 marked this pull request as draft April 28, 2026 18:42
@llorenc-11 llorenc-11 marked this pull request as ready for review April 28, 2026 19:10
@vkucera

vkucera commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

@MyFavoriteGitHub your username does not really identify you well in the collaboration.

vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx Outdated
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx Outdated
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx Outdated
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx Outdated
vkucera
vkucera reviewed Apr 29, 2026
View reviewed changes
Comment thread PWGJE/Tasks/jetHadronsPid.cxx Outdated
@llorenc-11 llorenc-11 requested review from a team, ddobrigk, dsekihat, iarsene, jgrosseo and ktf as code owners June 4, 2026 11:49
@alibuild alibuild mentioned this pull request Jun 4, 2026
Closed
@llorenc-11 llorenc-11 changed the title [PWGJE] Adding file jetHadronsPID.cxx and it's workflow [PWGJE] Adding file JetHadronsPID.cxx and it's workflow Jun 4, 2026
@llorenc-11 llorenc-11 changed the title [PWGJE] Adding file JetHadronsPID.cxx and it's workflow [Infrastructure,PWGJE] Adding file JetHadronsPID.cxx and it's workflow Jun 4, 2026
@vkucera

vkucera commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Please revert your commit modifying the MegaLinter configuration. If you want to update your branch, do it properly, according to the documentation.

@vkucera vkucera marked this pull request as draft June 4, 2026 12:06
@llorenc-11 llorenc-11 changed the title [Infrastructure,PWGJE] Adding file JetHadronsPID.cxx and it's workflow [PWGJE] Adding file JetHadronsPID.cxx and it's workflow Jun 4, 2026
@llorenc-11 llorenc-11 marked this pull request as ready for review June 4, 2026 13:07
@llorenc-11

llorenc-11 commented Jun 4, 2026

Copy link
Copy Markdown
Author

Sorry, I forgot I should have merged with upstream. I think the o2linter has problems with some other workflows, but those tasks already exist, so I did not change them.

@vkucera

vkucera commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Sorry, I forgot I should have merged with upstream. I think the o2linter has problems with some other workflows, but those tasks already exist, so I did not change them.

There are still warnings caused by your code.

@vkucera vkucera changed the title [PWGJE] Adding file JetHadronsPID.cxx and it's workflow [PWGJE] Add jetHadronsPID Jun 4, 2026
@alibuild

alibuild commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 7662242 at 2026-06-11 08:46:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 7662242 at 2026-06-12 08:38:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@llorenc-11

llorenc-11 commented Jun 16, 2026

Copy link
Copy Markdown
Author

@nzardosh Hi, are there any further steps I need to take for this pull request? The issues raised by alibuild seem to be resolved, but the final build check isn't starting. Please let me know if I need to take any action.

@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@llorenc-11 Please ignore the pending macOS build. It will not start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@raymondEhlers raymondEhlers Awaiting requested review from raymondEhlers raymondEhlers is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@vkucera vkucera Awaiting requested review from vkucera

@jgrosseo jgrosseo Awaiting requested review from jgrosseo

@iarsene iarsene Awaiting requested review from iarsene

@ktf ktf Awaiting requested review from ktf

@ddobrigk ddobrigk Awaiting requested review from ddobrigk

@dsekihat dsekihat Awaiting requested review from dsekihat

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@llorenc-11 @vkucera @alibuild @nzardosh @hzalewski